Search found 6 matches

by ChrisTX
Wed Nov 24, 2010 4:56 pm
Forum: [3.0/Olympus] Discussion
Topic: WinCache ACM backend
Replies: 13
Views: 18889

Re: WinCache ACM backend

I am really failing today, it seems. :oops: :roll: Everybody has these days where you're a bit off the track and such, don't take it too hard :D By the way, did I fulfill all the requirements for a proper pull request, or did I miss something considering formal aspects ( I'm new to git, that's why ...
by ChrisTX
Wed Nov 24, 2010 4:15 pm
Forum: [3.0/Olympus] Discussion
Topic: WinCache ACM backend
Replies: 13
Views: 18889

Re: WinCache ACM backend

I do, he implemented the ACM similary to me, that is by branching an existing backend. I started off acm_apc, he started off acm_xcache. If you'd look inside the file, you can also see the comment there, it's a left-over he forgot to remove. Same goes to the call to parent::acm_memory() in the const...
by ChrisTX
Wed Nov 24, 2010 3:23 pm
Forum: [3.0/Olympus] Discussion
Topic: WinCache ACM backend
Replies: 13
Views: 18889

Re: WinCache ACM backend

As I said, it is less efficient to implement _isset under these conditions, because that will cause serveral doubled queries, i.e. in destroy() of acm_memory, the _exists() function ( which refers to the _isset one ) will be called before _delete() and if it fails - and only then - it will skip the ...
by ChrisTX
Mon Nov 22, 2010 2:34 pm
Forum: [3.0/Olympus] Discussion
Topic: WinCache ACM backend
Replies: 13
Views: 18889

Re: WinCache ACM backend

I have an implementation of this sat in my repository, I've just never got around to testing it. https://github.com/cs278/phpbb3/compare/develop-olympus...feature%2Fwincache-acm Our implementations are pretty much the same, only you made _read return false on failure, like APC would do. I don't thi...
by ChrisTX
Sun Nov 21, 2010 3:56 pm
Forum: [3.0/Olympus] Discussion
Topic: WinCache ACM backend
Replies: 13
Views: 18889

Re: WinCache ACM backend

Hello, I think this could even go into 3.0.9-RC1 if it is working. :-) That'd be great. :) Is there any way I can test it more deeply than just being able to tell that my own forum can run it without any errors? I took a look into the tests at phpBB's git, but I couldn't see any ACM-specific tests t...
by ChrisTX
Sat Nov 20, 2010 11:05 pm
Forum: [3.0/Olympus] Discussion
Topic: WinCache ACM backend
Replies: 13
Views: 18889

WinCache ACM backend

Hello, I'm not exactly sure where to post this, but I made a ACM backend for Windows Cache for PHP (wincache) and wanted to share it. I wasn't able to test this on anything bigger than my own newly-setup forum, but it seems to be loaded fine, and I couldn't spot any issues with it so far. Since WinC...