Development Discussion Board

I see little value in this. Remote avatars are not actually copied to the board server, so the basic assumption ("feature already there for avatars") is faulty.

The sole benefit I see is that huge files might be added to a post much quicker by using the bigger bandwidth of servers. In this ...

The point is not to deny that some MODs need to alter the base code to function, it is the impossibility to support the installation of such MODs. File alterations mean that other MODs might not be installable at all; any automatic installer will fail. A core installer puts the burden of correctness ...

How are IE mime sniffing, flash's cross domain and java GIFAR attacks relevant to these static image types?

Sadly, all of these attacks use static images as their vector.

MIME header are already processed by mod_mime (and equiv functionality in IIS), so the concept of "enforcing" MIME types ...

we could also - shocking - use the same hook twice. With an argument from where in the function it was called.

Name: hook_template_snippet
Rationale: It's hard to deploy small markup additions over several templates. This hook enables code to inject code prior to template compilation, allowing MODs to alter several templates without changes to the actual template files. By using includes, these snippets can ...

Name: hook_link
Rationale: : Allow url rewriting for "pretty" URLs, adding GET arguments etc.
Input:
one array reference with the following fields
path : the path from the current document root
basename: basename of the script to invoke (can be empty)
vars: the query string, as key => value ...

Frankly, I don't see the benefit at all. Injecting javascript and CSS is something for the upcoming hooks system, not the bbcode system. It might be an idea to provide a hook for bbcodes requiring server-side actions, but that's as far as it goes.

Bottom line: wait for the hook placement call for ...

Debug: Unless DEBUG is defined, phpBB will disable any MODs that are triggering errors. MODs are not to use trigger error, but have to call the phpBB_message method instead. This behavior can be overridden.
How about exceptions?[/quote]

The problem is that trigger error - just like an exception ...

eviL3 wrote: Would there be any way to control the order in which the template code is injected? Would the proposed hook priorities allow that?

Precisely

I see no reason whatsoever for including such a functionality with the core. Users who really want their board to behave in such a fashion can add such a jquery snippet by themselves just fine - even with 3.0.

Note that the bandwidth to be saved is rather marginal - avatars are only loaded once by ...