Search found 27 matches

by dcz
Tue Oct 14, 2014 12:23 pm
Forum: [3.x] Discussion
Topic: Event scope in js
Replies: 0
Views: 1992

Event scope in js

Hello, Today I just felt on pieces of JS code like : // Hide active dropdowns when click event happens outside $body.click(function(e) { var $parents = $(e.target).parents(); if (!$parents.is(phpbb.dropdownVisibleContainers)) { $(phpbb.dropdownHandles).each(phpbb.toggleDropdown); } }); $('#phpbb').c...
by dcz
Wed Sep 03, 2014 7:03 am
Forum: [3.x] Event Requests
Topic: [PHP] core.pagination_generate_page_link
Replies: 9
Views: 5921

Re: [PHP] core.pagination_generate_page_link

Again, since there is one event in append_sid and ALL urls except pagination goes through it, it's a bit late for the questions you raise, even though they do make a lot of sense, especially the priority / order one.

Pagination is just the last non event-ed bit of url handling.
by dcz
Mon Sep 01, 2014 8:03 am
Forum: [3.x] Event Requests
Topic: [PHP] core.pagination_generate_page_link
Replies: 9
Views: 5921

Re: [PHP] core.pagination_generate_page_link

Well I don't know really. To me extending the pagination service is more efficient, but it may not be as handy as an event for some extension developers. It could be more consistent to have an event (as there is one in append_sid, you kinda need one for pagination to end the "event-able" urls), but ...
by dcz
Thu Jul 24, 2014 12:17 pm
Forum: [3.x] Event Requests
Topic: [PHP] core.pagination_generate_page_link
Replies: 9
Views: 5921

Re: [PHP] core.pagination_generate_page_link

Btw, your solution worked very smoothly.

Ty.
by dcz
Sat Jul 12, 2014 11:11 am
Forum: [3.x] Event Requests
Topic: [PHP] core.pagination_generate_page_link
Replies: 9
Views: 5921

Re: [PHP] core.pagination_generate_page_link

Basically a single function for generating arbitrary URLs is a bad idea. It should be the domain of the Service via the Router to generate URLs, not some magic function that has no knowledge of the current request or context. (Or at the least pass a router into the pagination to generate it by just...
by dcz
Fri Jul 11, 2014 11:38 am
Forum: [3.x] Discussion
Topic: Sommething wrong/blocking in overall_header.html
Replies: 11
Views: 5257

Re: Sommething wrong/blocking in overall_header.html

I tend to agree. We could do something like this: <!-- IF META_DESCRIPTION --><meta name="description" content="{META_DESCRIPTION}" /><!-- ENDIF --> We don't even need to define it. But just by including it in the header it will be trivial for extensions to define META_DESCRIPTION and use it. This ...
by dcz
Fri Jul 11, 2014 8:46 am
Forum: [3.x] Discussion
Topic: Sommething wrong/blocking in overall_header.html
Replies: 11
Views: 5257

Re: Sommething wrong/blocking in overall_header.html

Going down that path, you may as well use forum descriptions and topic content together with titles to build respective meta descriptions. But that's not the point. I'm not asking for what already exists ( here for example ) and I would not even mind phpBB to add dynamic meta tags in core, but rathe...
by dcz
Thu Jul 10, 2014 9:31 pm
Forum: [3.x] Discussion
Topic: Sommething wrong/blocking in overall_header.html
Replies: 11
Views: 5257

Re: Sommething wrong/blocking in overall_header.html

If my memory serves me right someone mentioned in another topic, that the description meta tag was supposed to be filled out by the forum owner himself and therefor is empty. If it was also somewhere mentioned that there was no acp-option for it to prevent an acp overkill. But don't quote me on thi...
by dcz
Thu Jul 10, 2014 12:52 pm
Forum: [3.x] Discussion
Topic: Sommething wrong/blocking in overall_header.html
Replies: 11
Views: 5257

Re: Sommething wrong/blocking in overall_header.html

I do not argue about usefulness of meta tags in SEO since there is none, but there are practical uses (site submission auto complete in third party site, google snipets in SERPs, etc ...) even though they are mostly cosmetic, they can find some actual use. Then, I even less argue with phpBB not impl...
by dcz
Thu Jul 10, 2014 12:35 pm
Forum: [3.x] Discussion
Topic: A way to actually control page titles
Replies: 2
Views: 1691

Re: A way to actually control page titles

Well, you cannot control what gets added to page_title. I mean, you probably can by using a late event (like in page_footer) and overwrite all template variables before you can actually set all of the page title but ... Keep in mind that if you really want to alter the title for your specific setup,...