Development Discussion Board

Hello,

Today I just felt on pieces of JS code like :
// Hide active dropdowns when click event happens outside
$body.click(function(e) {
var $parents = $(e.target).parents();
if (!$parents.is(phpbb.dropdownVisibleContainers)) {
$(phpbb.dropdownHandles).each(phpbb.toggleDropdown ...

Again, since there is one event in append_sid and ALL urls except pagination goes through it, it's a bit late for the questions you raise, even though they do make a lot of sense, especially the priority / order one.

Pagination is just the last non event-ed bit of url handling.

Well I don't know really.

To me extending the pagination service is more efficient, but it may not be as handy as an event for some extension developers. It could be more consistent to have an event (as there is one in append_sid, you kinda need one for pagination to end the "event-able" urls ...

Btw, your solution worked very smoothly.

Ty.

Basically a single function for generating arbitrary URLs is a bad idea. It should be the domain of the Service via the Router to generate URLs, not some magic function that has no knowledge of the current request or context. (Or at the least pass a router into the pagination to generate it by just ...

I tend to agree. We could do something like this:

<!-- IF META_DESCRIPTION --><meta name="description" content="{META_DESCRIPTION}" /><!-- ENDIF -->

We don't even need to define it. But just by including it in the header it will be trivial for extensions to define META_DESCRIPTION and use it ...

Going down that path, you may as well use forum descriptions and topic content together with titles to build respective meta descriptions. But that's not the point. I'm not asking for what already exists ( here for example ) and I would not even mind phpBB to add dynamic meta tags in core, but ...

If my memory serves me right someone mentioned in another topic, that the description meta tag was supposed to be filled out by the forum owner himself and therefor is empty. If it was also somewhere mentioned that there was no acp-option for it to prevent an acp overkill. But don't quote me on ...

I do not argue about usefulness of meta tags in SEO since there is none, but there are practical uses (site submission auto complete in third party site, google snipets in SERPs, etc ...) even though they are mostly cosmetic, they can find some actual use.

Then, I even less argue with phpBB not ...

Well, you cannot control what gets added to page_title. I mean, you probably can by using a late event (like in page_footer) and overwrite all template variables before you can actually set all of the page title but ...

Keep in mind that if you really want to alter the title for your specific ...