Search found 10 matches

by EA117
Sun Nov 10, 2019 2:58 pm
Forum: [3.x] Tickets Discussion
Topic: [PHPBB3-16207] Require cookies for sessions
Replies: 0
Views: 268

[PHPBB3-16207] Require cookies for sessions

https://tracker.phpbb.com/browse/PHPBB3-16207 The change in phpBB 3.2.6 which made "you must have the same session ID between receiving the login form and submitting the login form" a requirement (albeit indirectly via add_form_key() and check_form_key()) seems like it may have given us a preview fo...
by EA117
Wed Oct 23, 2019 12:58 am
Forum: [3.x] Discussion
Topic: Rewrite the URL's with extensions as before
Replies: 4
Views: 2012

Re: Rewrite the URL's with extensions as before

What is the presumed strategy that someone would be using to create human-readable URLs? Can it be as simple as packing the forum ID and topic ID into the path itself, such as /forum/81-71706/phpBB-3.x-Development/Rewrite-the-URL's-with-extensions-as-before ? Which side-steps the issue of "what if t...
by EA117
Mon Aug 26, 2019 11:30 am
Forum: [3.x] Discussion
Topic: phpBB 3.2.8-RC1 released
Replies: 9
Views: 4337

Re: phpBB 3.2.8-RC1 released

Issues resolved by pulling in the updated s9e/text-formatter might deserve a mention in the Bug Fixes list that goes public. Certain emoji characters no longer render correctly after phpBB 3.2.6 ( PHPBB3-16074 ) BBCodes using {TEXT} token in HTML tags may not work after phpBB 3.2.6. ( PHPBB3-16053 )
by EA117
Mon May 13, 2019 3:43 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.6 FORM_TOKEN on login
Replies: 5
Views: 5602

Re: phpBB 3.2.6 FORM_TOKEN on login

I don't believe that it is the responsibility of phpBB core to attempt to handle any and every feature that style developers, or for that matter extension developers, include in their respective developments... That is a completely fair point and perspective for looking at situations such as this. ...
by EA117
Mon May 13, 2019 12:18 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.6 FORM_TOKEN on login
Replies: 5
Views: 5602

Re: phpBB 3.2.6 FORM_TOKEN on login

This discussion on phpbb.com/community connected a couple dots I hadn't put together yet: Technically a phpBB 3.2.5 and earlier style could have offered the ability to login "from any page." i.e. Your template simply needed to decide "do I want to offer a login form here", and it could successfully...
by EA117
Wed May 08, 2019 12:22 am
Forum: [3.x] Discussion
Topic: "Normal reasons" for FORM_INVALID which now also apply to login forms.
Replies: 4
Views: 4748

Re: "Normal reasons" for FORM_INVALID which now also apply to login forms.

Right now I'm focusing on situations where "the sid is appended to the URL even though a cookie-based sid is also available." Because I feel like I can duplicate this user's "the anonymous session sid when building the login form on the index page is different than the anonymous session sid phpBB th...
by EA117
Sun May 05, 2019 10:29 pm
Forum: [3.x] Discussion
Topic: "Normal reasons" for FORM_INVALID which now also apply to login forms.
Replies: 4
Views: 4748

Re: "Normal reasons" for FORM_INVALID which now apply to login forms.

!empty('1'); returns true !empty('0'); returns false Thank you; exactly what I was failing to realize; the "or if the value equals FALSE" condition of "empty()". I will update the user to confirm that this setting should have an effect, by essentially making all logged-out user session sids "blank"...
by EA117
Sun May 05, 2019 10:02 pm
Forum: [3.x] Discussion
Topic: "Normal reasons" for FORM_INVALID which now also apply to login forms.
Replies: 4
Views: 4748

"Normal reasons" for FORM_INVALID which now also apply to login forms.

While poking at one of the users who still have "invalid form" during login, even with 3.2.7: https://www.phpbb.com/community/viewtopic.php?f=556&t=2510746&p=15248941#p15248941 Edit: Second customer encountered same problem in https://www.phpbb.com/community/viewtopic.php?f=556&t=2511881, and same w...
by EA117
Fri May 03, 2019 12:16 am
Forum: [3.x] Discussion
Topic: phpBB 3.2.6 FORM_TOKEN on login
Replies: 5
Views: 5602

Re: phpBB 3.2.6 FORM_TOKEN on login

Thanks for putting in such an efficient implementation of that approach; way less involved than what I had been picturing. Hopefully this does equate to less 3.2.7 upgrade friction, and ultimately fewer impacted users when S_FORUM_TOKEN_LOGIN support finally becomes mandatory again in 3.3.0.
by EA117
Tue Apr 30, 2019 1:13 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.6 FORM_TOKEN on login
Replies: 5
Views: 5602

phpBB 3.2.6 FORM_TOKEN on login

I see where https://tracker.phpbb.com/browse/PHPBB3-16036 identified that there are additional login forms which still needed the new FORM_TOKEN implementation. If there is to be a second push at getting this FORM_TOKEN implementation out there (meaning a phpBB 3.2.6.1 or whatever), is the fact that...