Search found 8 matches

by Toxyy
Sun Dec 03, 2023 11:22 pm
Forum: [3.x][Archive] RFCs
Topic: Sortable extension events
Replies: 33
Views: 120377

Re: Sortable extension events

Just PRd a proof of concept :) https://github.com/phpbb/phpbb/pull/6571 If approved, you could add priority to template events by hooking into the twig_tokenparser_constructor (name of event TBD) event in a listener. Example event usage: public function twig_tokenparser_constructor($event) { $templa...
by Toxyy
Mon Jun 26, 2023 8:44 am
Forum: [4.x] Discussion
Topic: Concept for dropping support for end of life DBMS
Replies: 3
Views: 20576

Re: Concept for dropping support for end of life DBMS

rxu wrote: Mon Jun 26, 2023 8:38 am
Marc wrote: Mon Jun 26, 2023 7:32 amSQLite 3.6.15+
What about SQLite 3.8.3+ which supports Common Table Expressions (CTE)?
I've asked about CTEs on the main phpbb forum so afaik the consensus is only if the others can support it as well would it be useful to consider?
by Toxyy
Sun Jan 27, 2019 9:42 pm
Forum: [3.x] Discussion
Topic: [RFC][3.3.x] Supported PHP versions
Replies: 31
Views: 131765

Re: [RFC][3.3.x] Supported PHP versions

It's been a couple of years and I'd like to point something out, doing some benchmarking for different symfony versions it doesn't look like 3.4 will be too much of an upgrade: http://www.phpbenchmarks.com/en/benchmark/siege/php-7.1/symfony-2.8.html http://www.phpbenchmarks.com/en/benchmark/siege/ph...
by Toxyy
Fri Jan 04, 2019 12:42 am
Forum: [3.x] Discussion
Topic: The sync function in includes/functions_admin.php
Replies: 2
Views: 11562

Re: The sync function in includes/functions_admin.php

Your code fix is backwards as the group by was used when there is more than one forum_id. However that overall fix would break the query when there is only one forum_id since the topic_id column is not agregated or grouped in that instance. You'd have to exclude it the same way you did the group by...
by Toxyy
Thu Jan 03, 2019 9:47 am
Forum: [3.x] Discussion
Topic: The sync function in includes/functions_admin.php
Replies: 2
Views: 11562

The sync function in includes/functions_admin.php

I've been going through here trying to add an event and the more I look at some of it the more I want to fix it... one example: if (count($forum_ids) == 1) { $sql = 'SELECT MAX(t.topic_last_post_id) as last_post_id FROM ' . TOPICS_TABLE . ' t WHERE ' . $db->sql_in_set('t.forum_id', $forum_ids) . ' A...
by Toxyy
Thu Jan 03, 2019 5:01 am
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 48
Views: 240995

Re: Ideas. Standard Style Improvements.

While I like the idea for a dark mode, there are browser extensions that sort of do this and would negate that, on top of the fact that anyone making a style would also have to figure out their dark pallete, essentially making every style two. That's a bit of additional work on their part. I'm not s...
by Toxyy
Sun Nov 18, 2018 7:00 pm
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 54
Views: 649813

Re: Moving developement discussion to Discord

@thrasher alpha#0036
role: troll
by Toxyy
Thu Aug 02, 2018 9:20 am
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 293528

Re: [NEW THEME] 4. JS frameworks & approach

AmigoJack wrote: Tue Jul 31, 2018 11:23 am Right now the navigation bar menus like "Quick links" don't work without JS, although it'd be doable thru CSS these days.
I'm an advocate for these sort of things, it makes me feel like I'm maintaining elegance while allowing them to work for non js users.