Search found 6 matches

by Toxyy
Sun Jan 27, 2019 9:42 pm
Forum: [3.x] Discussion
Topic: [RFC][3.3.x] Supported PHP versions
Replies: 31
Views: 50914

Re: [RFC][3.3.x] Supported PHP versions

It's been a couple of years and I'd like to point something out, doing some benchmarking for different symfony versions it doesn't look like 3.4 will be too much of an upgrade: http://www.phpbenchmarks.com/en/benchmark/siege/php-7.1/symfony-2.8.html http://www.phpbenchmarks.com/en/benchmark/siege/ph...
by Toxyy
Fri Jan 04, 2019 12:42 am
Forum: [3.x] Discussion
Topic: The sync function in includes/functions_admin.php
Replies: 2
Views: 3965

Re: The sync function in includes/functions_admin.php

Your code fix is backwards as the group by was used when there is more than one forum_id. However that overall fix would break the query when there is only one forum_id since the topic_id column is not agregated or grouped in that instance. You'd have to exclude it the same way you did the group by...
by Toxyy
Thu Jan 03, 2019 9:47 am
Forum: [3.x] Discussion
Topic: The sync function in includes/functions_admin.php
Replies: 2
Views: 3965

The sync function in includes/functions_admin.php

I've been going through here trying to add an event and the more I look at some of it the more I want to fix it... one example: if (count($forum_ids) == 1) { $sql = 'SELECT MAX(t.topic_last_post_id) as last_post_id FROM ' . TOPICS_TABLE . ' t WHERE ' . $db->sql_in_set('t.forum_id', $forum_ids) . ' A...
by Toxyy
Thu Jan 03, 2019 5:01 am
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 40
Views: 40713

Re: Ideas. Standard Style Improvements.

While I like the idea for a dark mode, there are browser extensions that sort of do this and would negate that, on top of the fact that anyone making a style would also have to figure out their dark pallete, essentially making every style two. That's a bit of additional work on their part. I'm not s...
by Toxyy
Sun Nov 18, 2018 7:00 pm
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 47
Views: 60078

Re: Moving developement discussion to Discord

@thrasher alpha#0036
role: troll
by Toxyy
Thu Aug 02, 2018 9:20 am
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 69987

Re: [NEW THEME] 4. JS frameworks & approach

AmigoJack wrote:
Tue Jul 31, 2018 11:23 am
Right now the navigation bar menus like "Quick links" don't work without JS, although it'd be doable thru CSS these days.
I'm an advocate for these sort of things, it makes me feel like I'm maintaining elegance while allowing them to work for non js users.