Development Discussion Board

Just PRd a proof of concept :) https://github.com/phpbb/phpbb/pull/6571 If approved, you could add priority to template events by hooking into the twig_tokenparser_constructor (name of event TBD) event in a listener. Example event usage: public function twig_tokenparser_constructor($event) { $templa...

rxu wrote: ↑Mon Jun 26, 2023 8:38 am

Marc wrote: ↑Mon Jun 26, 2023 7:32 amSQLite 3.6.15+

What about SQLite 3.8.3+ which supports Common Table Expressions (CTE)?

I've asked about CTEs on the main phpbb forum so afaik the consensus is only if the others can support it as well would it be useful to consider?

It's been a couple of years and I'd like to point something out, doing some benchmarking for different symfony versions it doesn't look like 3.4 will be too much of an upgrade: http://www.phpbenchmarks.com/en/benchmark/siege/php-7.1/symfony-2.8.html http://www.phpbenchmarks.com/en/benchmark/siege/ph...

Your code fix is backwards as the group by was used when there is more than one forum_id. However that overall fix would break the query when there is only one forum_id since the topic_id column is not agregated or grouped in that instance. You'd have to exclude it the same way you did the group by...

I've been going through here trying to add an event and the more I look at some of it the more I want to fix it... one example: if (count($forum_ids) == 1) { $sql = 'SELECT MAX(t.topic_last_post_id) as last_post_id FROM ' . TOPICS_TABLE . ' t WHERE ' . $db->sql_in_set('t.forum_id', $forum_ids) . ' A...

While I like the idea for a dark mode, there are browser extensions that sort of do this and would negate that, on top of the fact that anyone making a style would also have to figure out their dark pallete, essentially making every style two. That's a bit of additional work on their part. I'm not s...

@thrasher alpha#0036
role: troll

AmigoJack wrote: ↑Tue Jul 31, 2018 11:23 am Right now the navigation bar menus like "Quick links" don't work without JS, although it'd be doable thru CSS these days.

I'm an advocate for these sort of things, it makes me feel like I'm maintaining elegance while allowing them to work for non js users.