Search found 43 matches

by mrgoldy
Thu Jan 30, 2020 10:12 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 37126

Re: Control panel module system

So, the questions I still have, for which I need answers/verification: - Remove the module installation: \phpbb\install\module\install_data\task\add_modules - Remove the modules table in a new migration - Remove the database migration tool for modules: \phpbb\db\migration\tool\module - Remove the ad...
by mrgoldy
Fri Dec 20, 2019 10:28 am
Forum: [3.x] Discussion
Topic: Splitting off part of UCP
Replies: 7
Views: 3212

Re: Splitting off part of UCP

Oh, I like the idea of splitting them up into multiple parts. I was still in the mind set of 'get them out of there, i don't care where'. About Terms and Privacy needing to be available everywhere. Yes that's true, and it's not like they are no longer available afterwards. And you can explain it as ...
by mrgoldy
Wed Dec 18, 2019 11:13 am
Forum: [3.x] Discussion
Topic: Splitting off part of UCP
Replies: 7
Views: 3212

Re: Splitting off part of UCP

To clarify, the ucp will have the /user route prefix, so for example yourforum.com/user/index, etc
And I meant to use /account as route prefix for these, so for example yourforum.com/account/delete_cookies, etc
by mrgoldy
Tue Dec 17, 2019 7:53 pm
Forum: [3.x] Discussion
Topic: Splitting off part of UCP
Replies: 7
Views: 3212

Splitting off part of UCP

This is a discussion in regards to the User Control Panel. This will have to be done once the control panels (in general) have been moved. However, the discussion can already be started, so here we are. Currently there are quite a few modes that belong to the UCP, which do not really belong there. T...
by mrgoldy
Mon Dec 16, 2019 5:11 pm
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 7
Views: 4340

Re: Twig Function Semantic Naming

I remember when I first started coding, reading camelCase and PascalCase was really confusing to me. Perhaps that's cause I started coding with phpBB and it was using snake_case for all it's PHP functions. Now when I am rather comfortable with all kinds of coding languages, I don't really mind camel...
by mrgoldy
Mon Dec 02, 2019 5:39 pm
Forum: [3.x] Discussion
Topic: [TODOs/BLOCKERs] New Default Theme/Style Backend Requirments
Replies: 5
Views: 14125

Re: [TODOs/BLOCKERs] New Default Theme/Style Backend Requirments

Tempate system update This has to be changed so that all folders within the user's styles are added as paths. So that will mean that https://github.com/phpbb/phpbb/blob/master/phpBB/phpbb/template/twig/twig.php#L161 has to be changed, to find all folders within those styles and added as paths. Sear...
by mrgoldy
Fri Nov 29, 2019 4:21 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 37126

Re: Control panel module system

I mean, not automatically but it shouldn’t be too much work. It’s a major new release, they have to do some changes. Data from acp_info should be translated to the new parameters. And main_module should become a regular controller, which most extensions already do anyway. But this is not really I wa...
by mrgoldy
Fri Nov 29, 2019 2:08 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 37126

Re: Control panel module system

Control panel 'items' are now declared as service parameters. mcp.mcp_cat_main: route: 'mcp_index' mcp.mcp_index: parent: 'mcp_cat_main' route: path: /index defaults: _controller: mcp.front:main mcp.mcp_view_forum: auth: '(forum_id || topic_id || post_id) && acl_m_,forum_id' parent: 'mcp_cat_main' r...
by mrgoldy
Fri Nov 29, 2019 1:37 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 37126

Re: Control panel module system

Okay, so the initial conversion is complete. With a stack of 5 dependent PR's, everything is moved and functioning. ACP Modules to controllers MCP Modules to controllers UCP Modules to controllers CP Services and items CP Common code and tests The Travis and AppVeyor tests are also passing. However,...
by mrgoldy
Mon Sep 09, 2019 6:30 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 5731

Re: Read-only event variables

I understand the identifiers. They should probably be static. However, for example forum_data or topic_data is sometimes altered by extensions. I know of extensions (among others some of my/our own) that add (add, not alter) data to an event variable that is available within multiple events in a fil...