Development Discussion Board

For now the most reasonable option seems to be that we use PDO drivers and oci8, which covers all that we support now, the only drawback being people will need to have PDO installed for their database version, otherwise not much changes. This way we can use whatever parameters we want in prepared st...

AbaddonOrmuz wrote: ↑Wed Jan 13, 2021 9:31 pm Doctrine DBAL is built on top of PDO not mysqli, and pdo_mysql supports named parameters on prepared statements.

That is incorrect.

AbaddonOrmuz wrote: ↑Wed Jan 13, 2021 7:52 pm The Oracle driver does not support positional parameters, only named parameters, that's why the added their own parser.

mysqli doesn't support named params. Hence their drivers don't support both.

That is regarding prepared statements. So you cannot use the same parameters. Not all drivers support named parameters. The rest of SQL differences are handled similarly as the current DBAL, namely, you need to call a function to retreive the correct syntax, see sql_lower_text() etc for examples. Bu...

Having different SQL queries for different SQL drivers is a blocker as for me, having some compatibility layer to workaround this makes migration to Doctrine kinda useless as we get the same point of requiring maintenance for this layer. I'm not really sure if having different queries for different...

What advantages will Doctrine give to phpBB other than not having to maintain it? Are there features/facilities in Doctrine that phpBB needs ? Are there currently any issues with phpBB's DBAL? Prepared statements, more powerful query builder just to name a few. But not having to maintain our own DB...

My previous plans were to pull in Doctrine DBAL and suggest using it directly instead of our DBAL. This has quite a few advanteges: getting new features such as prepared statements, not having to maintain our own DBAL, etc. We would also keep our own interface, and implement it with Doctrine, so BC ...

I understand the identifiers. They should probably be static. However, for example forum_data or topic_data is sometimes altered by extensions. I know of extensions (among others some of my/our own) that add (add, not alter) data to an event variable that is available within multiple events in a fi...

The bigger question to me is how to implement this functionality to support an easy and clean declaration. Do you already have ideas on how to accomplish this? Well, first of I think we should just start documenting it in some way. Then we can start to think about if actually restricting the modifi...

There is a problem with our current way of handling events in the core. I think it would be a good idea to restrict certain variables from being modified in certain events. The main problem with the current system is that it event variables can be changed in events where it makes no sense which caus...