Search found 171 matches

by CHItA
Sun Jan 17, 2021 10:48 pm
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Re: Doctrine DBAL prepared statement troubles

For now the most reasonable option seems to be that we use PDO drivers and oci8, which covers all that we support now, the only drawback being people will need to have PDO installed for their database version, otherwise not much changes. This way we can use whatever parameters we want in prepared st...
by CHItA
Thu Jan 14, 2021 9:19 am
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Re: Doctrine DBAL prepared statement troubles

AbaddonOrmuz wrote: Wed Jan 13, 2021 9:31 pm Doctrine DBAL is built on top of PDO not mysqli, and pdo_mysql supports named parameters on prepared statements.
That is incorrect.
by CHItA
Wed Jan 13, 2021 8:31 pm
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Re: Doctrine DBAL prepared statement troubles

AbaddonOrmuz wrote: Wed Jan 13, 2021 7:52 pm The Oracle driver does not support positional parameters, only named parameters, that's why the added their own parser.
mysqli doesn't support named params. Hence their drivers don't support both.
by CHItA
Wed Jan 13, 2021 5:01 pm
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Re: Doctrine DBAL prepared statement troubles

That is regarding prepared statements. So you cannot use the same parameters. Not all drivers support named parameters. The rest of SQL differences are handled similarly as the current DBAL, namely, you need to call a function to retreive the correct syntax, see sql_lower_text() etc for examples. Bu...
by CHItA
Wed Jan 13, 2021 4:28 pm
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Re: Doctrine DBAL prepared statement troubles

Having different SQL queries for different SQL drivers is a blocker as for me, having some compatibility layer to workaround this makes migration to Doctrine kinda useless as we get the same point of requiring maintenance for this layer. I'm not really sure if having different queries for different...
by CHItA
Wed Jan 13, 2021 10:19 am
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Re: Doctrine DBAL prepared statement troubles

What advantages will Doctrine give to phpBB other than not having to maintain it? Are there features/facilities in Doctrine that phpBB needs ? Are there currently any issues with phpBB's DBAL? Prepared statements, more powerful query builder just to name a few. But not having to maintain our own DB...
by CHItA
Tue Jan 12, 2021 8:19 pm
Forum: [4.x] Discussion
Topic: Doctrine DBAL prepared statement troubles
Replies: 20
Views: 596

Doctrine DBAL prepared statement troubles

My previous plans were to pull in Doctrine DBAL and suggest using it directly instead of our DBAL. This has quite a few advanteges: getting new features such as prepared statements, not having to maintain our own DBAL, etc. We would also keep our own interface, and implement it with Doctrine, so BC ...
by CHItA
Mon Sep 09, 2019 6:40 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 9099

Re: Read-only event variables

I understand the identifiers. They should probably be static. However, for example forum_data or topic_data is sometimes altered by extensions. I know of extensions (among others some of my/our own) that add (add, not alter) data to an event variable that is available within multiple events in a fi...
by CHItA
Mon Sep 09, 2019 5:04 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 9099

Re: Read-only event variables

The bigger question to me is how to implement this functionality to support an easy and clean declaration. Do you already have ideas on how to accomplish this? Well, first of I think we should just start documenting it in some way. Then we can start to think about if actually restricting the modifi...
by CHItA
Sun Sep 08, 2019 10:54 am
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 9099

Read-only event variables

There is a problem with our current way of handling events in the core. I think it would be a good idea to restrict certain variables from being modified in certain events. The main problem with the current system is that it event variables can be changed in events where it makes no sense which caus...