Search found 45 matches

by martti
Tue May 05, 2020 8:58 am
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

Here is a list of scopes O- CSS Object C- CSS Component T- CSS Theme U- CSS Utility IS- CSS Action HAS- CSS Action JS- CSS JS Hook F- Twig Function _ CSS Temp Hack Why are these useful, well not only do they tel us what there role is but they offer us the advantage in our IDE to allow us to look th...
by martti
Tue May 05, 2020 4:51 am
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

It looks like things are getting a bit heated here. There is no need to resort to passive aggressive comments towards each other. Right. Now it's about how I need to be "educated" because I see HTML attributes just as ... HTML attributes and not as CSS or JS. So dumb of me, I'm not capable of separ...
by martti
Sat May 02, 2020 8:53 pm
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

hanakin wrote: Sat May 02, 2020 7:27 pm

Code: Select all

<li class="o-list-item c-topic-item t-topic-item" role="row">
                    ^ this is CSS an object to be specific!!!!
It's just an HTML tag with attributes.
It might be used as a selector by the styling sheet.
by martti
Sat May 02, 2020 6:25 am
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

So I agree with the others, keep it a_function_in_twig() because there's no confict. There is no php, css or js in .html.twig files. And if there is, then that's the real issue. There is already a convention in phpBB And most of the rest of the world outside this littlle phpBB corner uses the same a...
by martti
Tue Apr 28, 2020 3:30 pm
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

A good thing to do I think will be to prefix template functions that come from phpBB extensions like ext_vendorname_extensionname_ or just vendorname_extensionname_ That shows immediately "where it comes from" and what's responsible for it. and hints "what it does" The same namespacing pattern every...
by martti
Tue Apr 28, 2020 10:34 am
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

Uhm? I hope not to find any js or css in there? We use the template engine to construct html, no?
by martti
Sun Apr 26, 2020 6:32 pm
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

And I forgot to mention still another thing that this function does:

Code: Select all

{{ JumbBox() }}
Namely, it triggers a PHP event.
Now, isn't that a design flaw and crossing the borders of concern that we can trigger a PHP event from our template?
by martti
Sun Apr 26, 2020 6:14 pm
Forum: [3.x] Discussion
Topic: Twig Function Semantic Naming
Replies: 31
Views: 24450

Re: Twig Function Semantic Naming

I just happen to find here only vague motivations. So naturally I go look elsewhere to see what's behind all this. So let's start where it started: {{ JumpBox() }} I think this function is doing too much. Unfortunately, like many other functions in phpBB. If it was split up in smaller parts or conce...
by martti
Sat Apr 25, 2020 7:13 pm
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 54
Views: 100278

Re: Moving developement discussion to Discord

JoshyPHP wrote: Sat Apr 25, 2020 6:54 pm 3M makes post-its. Eat your dog food.
Well, that sounds indeed as not much belief in phpBB as a discussion platform.
by martti
Sat Apr 25, 2020 6:43 pm
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 54
Views: 100278

Re: Moving developement discussion to Discord

JoshyPHP wrote: Sun Apr 12, 2020 3:19 pm Counterpoint: I don't think 3M conduct their meetings via Post-its.
I'm sorry, I don't understand that remark. What do you mean?