Development Discussion Board

More like around 15~~18

I agree, it's off topic, but if you think the benefits so you have reason...

Unknown Bliss wrote: But if I'm honest this seems like a pointless micro-optimisation and is probably not worth it.

That "micro-optimisation" like you call it, is a non-negligible optimization for big board with many forum, many users, many trafic and probably more...

Nope, you don't understand....
See below:
$user_data = $user->data;

while ( $row = $db->sql_fetchrow($result) )
{
$template->assign_block_vars('our_block', array(
'USERNAME' => $user_data['username'],
'USER_ID' => $user_data['user_id'],
'USER_EMAIL' $user_data['user_email'],
//AND MANY ...

nickvergessen wrote:the number of circles is mostly <100

I agree, but the specific purpose of 3.1.x isn't to optimize the phpbb core untill the most little optimization??
And the specific purpose of this topic isn't to worth the confussion, but to involve in the phpBB project, don't take it bad bro :/

Memberlist.php:
Around line 171~~
while ($row = $db->sql_fetchrow($result))
In the while you call:
if ($auth->acl_get('f_list', $forum_id))
(Okey for this, it's not easy to replace by a var i agree)
but after:
if ($row['group_type'] == GROUP_HIDDEN && !$auth->acl_gets('a_group', 'a_groupadd ...

http://pastebin.com/VNiQKqPK
All is there...
Result returned:
While acl(method) time:0.00136113166809s
While acl(var) time:8.10623168945E-5s
No need to explain i think... :roll: :roll:

Look @ search.php, viewtopic.php, and function_display.php...
Search for $auth->acl_get(s) method in while and ...

Hello
i've see a thing with the phpbb FR Team: For all Mod we made, we call many time $auth->acl_get('AN_ACL') but we've see if we assign to a var like: $acp_acl = $auth->acl_get('a_') the spend time php is very reduced
50 call with $auth->acl_get('a_') 0.065s
1 call of $auth->acl_get('a_') with 49 ...

What is your use case for this change?

Normally you should not care where the parameter is coming from.

You could require, say, passwords to be sent via a form submission only, protecting them from being exposed in server logs, but who would send them in query strings in the first place? You ...

Hello, for phpbb 3.1.x i would know if it's possible to integrate a 5th parameter at request_var()
$myvar = request_var('myinput', '', false, false, 'get')
or
$myvar = request_var('myinput', '', false, false, 'post')
Explaining: Possibility to choice GET or POST when we call request_var...
I ...