Search found 17 matches

by kasimi
Thu Jun 11, 2020 8:20 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.10-RC2 released
Replies: 33
Views: 81527

Re: phpBB 3.2.10-RC2 released

I don't know if this is a bug in 3.2.10-RC2 or a problem just with phpbb.com, but wildcard searches aren't working as expected. Search in topic titles only, display results as topics, search for authenticat* . I would expect many topics in the results with authentication in their title, but I get 0 ...
by kasimi
Sat Jan 26, 2019 6:24 pm
Forum: General Development Discussion
Topic: notification method is_available() (possible) bug
Replies: 2
Views: 17713

Re: notification method is_available() (possible) bug

This looks like by design to me. The auth instance you get from the container always belongs to the user of the current request. The notification methods simply weren't built with support for user-depending availability in mind. :|
by kasimi
Thu Dec 06, 2018 8:26 am
Forum: General Development Discussion
Topic: Renderer class - why these two variables are different
Replies: 5
Views: 27554

Re: Renderer class - why these two variables are different

mikovchain wrote: Thu Dec 06, 2018 4:57 am the variable $renderer equals to $this->renderer
Not quite:

$renderer !== $this->renderer

because

$renderer === $this

therefore

$renderer->renderer === $this->renderer
by kasimi
Tue Nov 27, 2018 9:13 am
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 54
Views: 565040

Re: Moving developement discussion to Discord

I'm #3709. The other kasimi #4467 can be removed, that was also me but from a different computer, not sure why I was able to get the same username. Isn't that supposed to be disallowed?
by kasimi
Sun Oct 22, 2017 6:06 pm
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 11443

Re: Indicate who hasn't read a multi-user PM

When viewing a message, adding the unread information is a minor change as there are to_recipient and bcc_recipient blocks being used already. When viewing a folder, the recipient names are just a string, getting joined before being assigned to the template. The function that fetches the names only...
by kasimi
Sun Oct 22, 2017 10:17 am
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 11443

Re: Indicate who hasn't read a multi-user PM

When sending to users (as opposed to groups), the data is already there, it just needs to be displayed. There won't be any performance penalties.

For multi-groups this will not work, just like it isn't working at the moment when sending to a single group. But we've gotta start somewhere. :P
by kasimi
Sun Oct 22, 2017 8:59 am
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 11443

Indicate who hasn't read a multi-user PM

When sending a PM to a single user, you know the user has read them PM when it has been moved from your Outbox to your Sent messages folder. When sending a PM to multiple users, the PM is moved the moment the first user reads it. There is no way to know who the first reader was and who hasn't read t...
by kasimi
Mon Sep 25, 2017 5:01 pm
Forum: [3.x] Discussion
Topic: [RFC] buggy function banned user ids
Replies: 1
Views: 6827

Re: [RFC] buggy function banned user ids

0 is the correct value here because the query is selecting banned users, as opposed to banned emails or IPs for which ban_userid whould be 0. If you change it to <> 1, the returned array contains an invalid entry.
by kasimi
Thu Nov 24, 2016 2:28 pm
Forum: [3.x] Discussion
Topic: Prevent deletion of built-in permission roles
Replies: 3
Views: 10840

Re: Prevent deletion of built-in permission roles

I think the migrator should take care of this. If the role doesn't exist, the permission.permission_set operation should be skipped, without throwing an error. Admins who delete built-in roles should know that extension won't be able to set default permission values. Either that, or don't allow dele...
by kasimi
Fri Sep 23, 2016 5:22 pm
Forum: [3.x] Discussion
Topic: "Mark forums read" can be pressed accidentally in mobile devices
Replies: 11
Views: 28158

Re: "Mark forums read" can be pressed accidentally in mobile devices

There's an extension in [DEV] for this. The confirmation only works with JavaScript enabled though.

https://www.phpbb.com/community/viewtop ... &t=2357461