Search found 42 matches

by _hsr
Fri May 04, 2012 11:43 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Javascript Coding Style
Replies: 17
Views: 40314

Re: [RFC] Javascript Coding Style

@callum, I'd like to work on writing the guidelines too, enlighten me with the source :p
by _hsr
Fri May 04, 2012 11:38 am
Forum: [3.x][Archive] RFCs
Topic: Private message notifications
Replies: 23
Views: 34142

Re: [RFC] Improved PM Notification

viewtopic.php?f=108&t=42761 < same copy here, someone please merge the threads :roll:
by _hsr
Thu Apr 26, 2012 4:00 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 153737

Re: [RFC] Multiple file uploads

That looks promising.
Just using html5 is not a good idea imo, there should be a fallback option, just in case the user has not upgraded to the latest version. I say use html5 and gears/flash, where gears/flash be the fallback for html5. And the old upload mechanism should exist, they should only be ...
by _hsr
Wed Apr 25, 2012 6:29 am
Forum: [3.x] Discussion
Topic: Receive/Send Trackbacks
Replies: 10
Views: 16135

Re: Receive/Send Trackbacks

+1 for this, would be helpful for a scenario where there's a blog and a forum on a website etc..
by _hsr
Wed Apr 25, 2012 5:40 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 153737

Re: [RFC] Multiple file uploads

I've had the chance to test it on the following browsers,

Opera 11.x > defaults to flash
Chrome 17.x > defaults to html5
Firefox 9.x > defaults to html5
Safari > defaults to html5
IE 7(compatibility mode) > defaults to silverlight
IE 8(compatibility mode) > defaults to flash
IE 9 > defaults to ...
by _hsr
Wed Apr 25, 2012 2:41 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 153737

Re: [RFC] Multiple file uploads

html5 is not available in all browsers as of now. I say we include flash and/or silverlight in the package and let the admins choose the preferred framework. It is just a matter of including a string in it's configuration.

@fyorl, I had made a branch on github for this project, will update it with ...
by _hsr
Tue Apr 24, 2012 1:13 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 153737

Re: [RFC] Multiple file uploads

handing over all the responsibility to fyorl, take it home buddy ;)
by _hsr
Thu Apr 19, 2012 8:37 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Javascript Coding Style
Replies: 17
Views: 40314

Re: [RFC|Accepted] Coding Guideline Modifications

Parentheses?
Or do you mean curly braces?

And if you are saying the second one is wrong, as in this one:
phpbb.add_ajax_callback = function(id, callback)
{
if (typeof callback === 'function')
{
phpbb.ajax_callbacks[id] = callback;
}
return this;
}

It is from core.js, the original.

The ...
by _hsr
Thu Apr 19, 2012 6:22 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Javascript Coding Style
Replies: 17
Views: 40314

[RFC|Merged] Javascript Coding Style

phpbb.attachment_lightbox() {
this.init = function() {
if(this.sources === undefined) {
return this.addSources();
}
else {
return this.enable();
}
}
}

This is a piece of code I'm working on right now, and I'd like to suggest the following changes:

phpbb.add_ajax_callback = function(id ...
by _hsr
Sun Apr 15, 2012 1:17 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Quote with link to original post
Replies: 22
Views: 79721

Re: [RFC] Quote with link to original post

+1 with linking posts that are quoted with the quote button
-1 for the user nickname linking