Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
-
Nicofuma
- 3.2 Release Manager

- Posts: 298
- Joined: Sun Apr 13, 2014 1:40 am
- Location: Paris
Post
by Nicofuma » Fri Aug 08, 2014 12:55 pm
Now you are able to add or remove the WIP label to your own PRs, for that you need to post a special comment to your PR:
to set the WIP label
to remove it
Example:
https://github.com/phpbb/phpbb/pull/268 ... t-51595801
Member of the phpBB Development-Team
No Support via PM
-
nickvergessen
- Former Team Member
- Posts: 733
- Joined: Sun Oct 07, 2007 11:54 am
- Location: Stuttgart, Germany
-
Contact:
Post
by nickvergessen » Sat Aug 09, 2014 8:44 am
The development team will try to set your PRs to WIP if work needs to be done.
If you think you fixed all issues, just remove the WIP label again, so we can review it again.
Member of the Development-Team — No Support via PM
-
brunoais
- Registered User
- Posts: 964
- Joined: Fri Dec 18, 2009 3:55 pm
Post
by brunoais » Sat Aug 09, 2014 10:14 am
Ah! I didn't know such thing existed!
How did you do it? I want that for me as well!
-
Nicofuma
- 3.2 Release Manager

- Posts: 298
- Joined: Sun Apr 13, 2014 1:40 am
- Location: Paris
Post
by Nicofuma » Sat Aug 09, 2014 11:21 am
Member of the phpBB Development-Team
No Support via PM
-
VSE
- Extension Customisations

- Posts: 670
- Joined: Mon Mar 08, 2010 9:18 am
Post
by VSE » Sat Aug 09, 2014 10:54 pm
Can we also have !set EVENT
to add the Event label to event PRs?
Has an irascible disposition.
-
MichaelC
- Development Team

- Posts: 889
- Joined: Thu Jan 28, 2010 6:29 pm
Post
by MichaelC » Mon Aug 11, 2014 10:36 am
VSE wrote:Can we also have !set EVENT
to add the Event label to event PRs?
Should work due to
https://github.com/phpbb/dev-hooks/pull/2
Formerly known as Unknown Bliss
psoTFX wrote:
I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
-
hanakin
- Infrastructure Team

- Posts: 871
- Joined: Sat Dec 25, 2010 9:02 pm
-
Contact:
Post
by hanakin » Mon Aug 11, 2014 2:46 pm
Maybe instead of just turning the WIP on or off we could also have on for Ready for Review !set REVIEW
-
VSE
- Extension Customisations

- Posts: 670
- Joined: Mon Mar 08, 2010 9:18 am
Post
by VSE » Mon Aug 11, 2014 8:14 pm
One side effect. When subscribed to a pr you may get an email when a set WIP comment is made.
Has an irascible disposition.
-
MichaelC
- Development Team

- Posts: 889
- Joined: Thu Jan 28, 2010 6:29 pm
Post
by MichaelC » Fri Aug 15, 2014 12:04 am
VSE wrote:One side effect. When subscribed to a pr you may get an email when a set WIP comment is made.
The other side to that is you also get an email when !unset WIP is run so you know the author has made changes/fixed something and it's ready for review.
Formerly known as Unknown Bliss
psoTFX wrote:
I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
-
hanakin
- Infrastructure Team

- Posts: 871
- Joined: Sat Dec 25, 2010 9:02 pm
-
Contact:
Post
by hanakin » Fri Aug 15, 2014 4:49 am
Does this work from the original PR message? Say I create a new PR and add !set WIP or Style to the bottom of the PR message when I initially create it?