[RFC] Hide forum (f) variable from topic url

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Hide forum (f) variable from topic url

Post by DavidIQ » Tue May 27, 2014 4:44 pm

Isn't the forum being determined internally for other features when it's not present? i.e. the breadcrumbs.
Image

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Hide forum (f) variable from topic url

Post by nickvergessen » Wed May 28, 2014 6:56 am

Well we create the parameter later on viewtopic, but when we create the session entry nothing has been done and we need the session/auth to do stuff
Member of the Development-TeamNo Support via PM

User avatar
Volksdevil
Registered User
Posts: 84
Joined: Tue Sep 04, 2012 2:17 pm
Contact:

Re: [RFC] Hide forum (f) variable from topic url

Post by Volksdevil » Wed May 28, 2014 10:43 pm

nickvergessen wrote:It's not only about showing "yourself", but it doesnt show "yourself" to anyone. So when we remove it from the URL, the feature becomes quite useless, as everyone does not show to anyone.
Ah, understood. So it's more of an issue than it first seems. It's not really my thing but, can it not be fixed via a query somewhere? Apologies if that sounds too 'Simple' but like I say, database stuff is way over my head.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Hide forum (f) variable from topic url

Post by nickvergessen » Thu May 29, 2014 7:43 pm

yes, 1 additional query on the most loaded page of phpbb for each page call, instead of adding simple 4 characters to some urls
Member of the Development-TeamNo Support via PM

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: [RFC] Hide forum (f) variable from topic url

Post by Louis7777 » Fri May 30, 2014 12:08 am

nickvergessen wrote:It's not only about showing "yourself", but it doesnt show "yourself" to anyone. So when we remove it from the URL, the feature becomes quite useless, as everyone does not show to anyone.
Shouldn't this be considered a major bug?


Here's why I think that:

Some time ago we had the problem of duplicate links. Now that we point to canonical links that problem hopefully belongs to the past. However, Google will now serve the canonical links, which means that all visitors coming from search engines will have clicked on links without the f= parameter and as a result they will be all browsing as invisible.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Hide forum (f) variable from topic url

Post by nickvergessen » Fri May 30, 2014 9:37 am

Louis7777 wrote:Some time ago we had the problem of duplicate links. Now that we point to canonical links that problem hopefully belongs to the past. However, Google will now serve the canonical links, which means that all visitors coming from search engines will have clicked on links without the f= parameter and as a result they will be all browsing as invisible.
No, they will just be listed as browsing the board instead of a topic in this particular forum.
Also as soon as they use the pagination, they will be listed in the forum.

But yes, all this is a bug, so we use this easy workaround (adding f= to the url)
Member of the Development-TeamNo Support via PM

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [RFC] Hide forum (f) variable from topic url

Post by Sumanai » Fri May 30, 2014 12:56 pm

Louis7777 wrote:However, Google will now serve the canonical links, which means that all visitors coming from search engines will have clicked on links without the f= parameter and as a result they will be all browsing as invisible.

Absence of the parameter f= in canonical link is a mistake, I believe.
Sorry for my English.

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: [RFC] Hide forum (f) variable from topic url

Post by Louis7777 » Fri May 30, 2014 4:37 pm

Sumanai wrote: Absence of the parameter f= in canonical link is a mistake, I believe.
And the reason is...?

User avatar
Sumanai
Registered User
Posts: 95
Joined: Sat Aug 31, 2013 11:12 am

Re: [RFC] Hide forum (f) variable from topic url

Post by Sumanai » Fri May 30, 2014 6:24 pm

Canonical version should be one the most common. Now most references on the forum with the parameter f =.
I think a mistake that all the links are with the parameter f =, and the canonical version without
Sorry for my English.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Hide forum (f) variable from topic url

Post by nickvergessen » Sat May 31, 2014 12:23 am

well we use without f= so when the topic is moved, the canonical URL does not change.
Otherwise you get duplicate pages again, because the old links will still work
Member of the Development-TeamNo Support via PM

Post Reply