[RFC|Rejected] Font sizes as font sizes

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
Post Reply
User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

[RFC|Rejected] Font sizes as font sizes

Post by callumacrae » Wed Apr 18, 2012 3:24 pm

I really don't understand why the size BBCode uses random numbers. Why not just accept 16pt, 18px as sizes? I know what 16pt is, but I don't know what 200 is, so I have to use the button every time I want to change the size, when it might want to type it.
Made by developers, for developers!
My blog

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Font sizes as font sizes

Post by imkingdavid » Wed Apr 18, 2012 5:11 pm

Currently it goes by percent, afaik. i.e. 200 is 2x normal font size. 100 is normal font size (i.e. 100%). I don't have a problem with using pt and px as well if either is specified, but we should not remove the current percentage functionality, especially so we don't break BC.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
brunoais
Registered User
Posts: 962
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Font sizes as font sizes

Post by brunoais » Wed Apr 18, 2012 8:53 pm

I go with adding functionality so that we could also use pt.

Code: Select all

[size=20pt][/size]
Should be something valid...

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Font sizes as font sizes

Post by imkingdavid » Wed Apr 18, 2012 10:58 pm

I think if we allow non-integer characters, those should be in quotes. But I'm not sure how it all works right now with the current bbcode parser, so i'm not sure if we can allow both with and without quotes depending on the value.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Font sizes as font sizes

Post by Oleg » Thu Apr 19, 2012 6:20 am

I think percentages are fine.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Font sizes as font sizes

Post by callumacrae » Thu Apr 19, 2012 7:29 am

Oleg wrote:I think percentages are fine.
I had absolutely no idea that they were percentages, and I'm on the team. It should be obvious how the sizes work.
Made by developers, for developers!
My blog

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Font sizes as font sizes

Post by imkingdavid » Thu Apr 19, 2012 10:47 pm

callumacrae wrote:
Oleg wrote:I think percentages are fine.
I had absolutely no idea that they were percentages, and I'm on the team. It should be obvious how the sizes work.
If using "Normal" size creates a

Code: Select all

[size=100][/size]
tag and makes the font size the same as when it doesn't have font tags, it's pretty obvious that the numbers are percents.

Anyway, as I said, as long as we retain current behavior for the bbcode button, I'm okay with someone implementing the ability to use pt and px for those who know how. However percents of > 200 and < 50 are not accepted by the BBcode engine, so if pt and px are implemented, they should have a maximum and minimum that are equal to the size created by using percents (I'm not sure offhand what they are, you'd have to take font size at 100% and determine its pt and px and then calculate the pt and px for fonts at 50 and 200 percent).
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Font sizes as font sizes

Post by Oleg » Fri Apr 20, 2012 5:40 am

Relative font sizes have the advantage of working when font size changes.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Font sizes as font sizes

Post by callumacrae » Fri Apr 20, 2012 8:45 am

Oleg wrote:Relative font sizes have the advantage of working when font size changes.
Which was removed in 3.1 :-)
Made by developers, for developers!
My blog

User avatar
Arty
Registered User
Posts: 971
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Font sizes as font sizes

Post by Arty » Fri Apr 20, 2012 12:18 pm

callumacrae wrote:
Oleg wrote:Relative font sizes have the advantage of working when font size changes.
Which was removed in 3.1 :-)
But styles might still use different font size.

Default prosilver uses 13px Lucida Grande or Trebuchet MS font. If its changed to Arial or Helvetica, font would become smaller. To make bbcode look the same, font=100 must be 13px for prosilver, 14px for style that uses Arial. Using percentages makes much more sense.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

Post Reply