Drop php closing tags

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Drop php closing tags

Post by igorw »

I know none except for the install files. Give me a use case where a MOD would look for a ?> that is not the EOF.
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Drop php closing tags

Post by igorw »

I am bumping this. For new files the ?> is being dropped (this was adjusted in the coding guidelines), however it has not yet been decided how to handle existing files.

I'm still in favour of adjusting the existing files for 3.1.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Drop php closing tags

Post by imkingdavid »

eviL3 wrote:I'm still in favour of adjusting the existing files for 3.1.
This.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
APTX
Registered User
Posts: 680
Joined: Thu Apr 24, 2003 12:07 pm

Re: Drop php closing tags

Post by APTX »

eviL3 wrote:I'm still in favour of adjusting the existing files for 3.1.
Yes!
Don't give me my freedom out of pity!
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: Drop php closing tags

Post by igorw »

Added a patch to the ticket.
User avatar
3Di
Registered User
Posts: 864
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: Drop php closing tags

Post by 3Di »

igorw wrote:I know none except for the install files. Give me a use case where a MOD would look for a ?> that is not the EOF.
the Pastebin MOD, while using the PHP Syntax Highlighter, searchs for SCRIPT_DELIMITERS, in this case searching for it also and not only.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫
Post Reply