PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Wed Jul 19, 2017 5:27 pm

Great! Thank you.
I'll see if I get any useful time to deal with this during the holiday season. I doubt it but... It's good to expect.
If I get time for this, I'll just make something for the quote tag and move along.
As for the default editor.... It may be that pell does what we want or maybe Rin, or maybe SCE is good enough now.
Regardless of the choice. Most of this feature is to the editor by design. I just wish I had a way to deal with the major drawback, which is the new current quote tag

User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by Meis2M » Sat Jul 22, 2017 4:02 pm

How is Rineditor? it is base on ckeditor .
is that work with quote tag ?

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Mon Jul 24, 2017 3:15 pm

The problem with the quote tag is unrelated to the editor itself. It is related to the agnostic API for the WYSIWYG editor.
I'm having a really very hard time translating from its hard code definition into a "soft-code" definition. And so far, no help has been given.

User avatar
Ger
Registered User
Posts: 270
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by Ger » Thu Jul 27, 2017 7:37 am

So basically you have everything working except for the quote-tag? If that's the case, can you elaborate on the exact issue you run into? It's probably somewhere in this topic, but I can't seem to find it...
Is it just about indenting nested quotes?
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Thu Jul 27, 2017 10:26 am

Ger wrote:
Thu Jul 27, 2017 7:37 am
So basically you have everything working except for the quote-tag? If that's the case, can you elaborate on the exact issue you run into? It's probably somewhere in this topic, but I can't seem to find it...
Is it just about indenting nested quotes?
The quote tag has many features. It has the user, the post id, the time of posting and the user id from where the post came from.
unfortunately, though, some are dynamic... Maybe too dynamic (just an expression. Not really). See here:
https://github.com/phpbb/phpbb/blob/mas ... er.php#L59

What is featured in there is, what I would call, my biggest nightmare for this ticket. The post and the user_id can be handled somehow with dummy or whatever but the date requires formatting according to the user's preferences.
So I'm stuck at this. I dunno how much can be viably cut out and how much has to stay. I've been waiting for help for a long time with this but I still didn't get any in the last year and some months...
If using dummy information, what level of "dummyness" should I use?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by DavidIQ » Thu Jul 27, 2017 12:10 pm

Don't understand what's blocking you. Why does having that information in the quote tag affect what you are doing and not everything else, especially custom BBCodes?
Image

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Thu Jul 27, 2017 12:19 pm

Because custom BBCodes is already solved.
The hardest ones are the ones are built-in because they use custom specs.
After all those, though. I had found solutions except for the quote. I've asked for help at the time on how to proceed but I got no answers. So I blocked.

User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by Meis2M » Thu Jul 27, 2017 12:41 pm

this is from rin editor in wysiwyg mode:
7-27-2017 17-08-48.png
where is that wrong?

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Thu Jul 27, 2017 12:58 pm

I don't know
I just need to know how to proceed when I encounter such kind of tag.
About Rin editor itself:
Try making it work with a custom BBCode and see it failing.

User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by Meis2M » Thu Jul 27, 2017 1:03 pm

custom bbcode like quote must be render in wysiwyg mod?

Post Reply