[RFC] Smilies in a dropdown box

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
sahil505
Registered User
Posts: 5
Joined: Tue Feb 28, 2017 3:49 pm

Re: [RFC] Smilies in a dropdown box

Post by sahil505 »

How can I get the existing code so that I can add on to it the drop-down feature?

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Smilies in a dropdown box

Post by hanakin »

everything should be in the guide i emailed you but you can start by forking the repo https://github.com/phpbb/phpbb/tree/master
Donations welcome via Paypal Image

sahil505
Registered User
Posts: 5
Joined: Tue Feb 28, 2017 3:49 pm

Re: [RFC] Smilies in a dropdown box

Post by sahil505 »

should i consider it as an improvement or new feature? Also what is the project type? Website (WEBSITE)?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1903
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Smilies in a dropdown box

Post by DavidIQ »

Website tracker is for the website so phpBB core work has no connection to that tracker.
Image

sahil505
Registered User
Posts: 5
Joined: Tue Feb 28, 2017 3:49 pm

Re: [RFC] Smilies in a dropdown box

Post by sahil505 »

well i just created an issue https://tracker.phpbb.com/browse/WEBSITE-1316. how do i create ticket from this?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1903
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Smilies in a dropdown box

Post by DavidIQ »

I've moved it to the correct tracker. Please create future tickets in the correct tracker, in this case the PHPBB3 tracker, as the WEBSITE tracker is for issues with our websites under the phpbb.com domain.
Image

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Smilies in a dropdown box

Post by hanakin »

Something along the same lines might be just as beneficial or more so now that we support emojis is to have some sort of tool to enter them. Might do away with them completely?
Donations welcome via Paypal Image

sahil505
Registered User
Posts: 5
Joined: Tue Feb 28, 2017 3:49 pm

Re: [RFC] Smilies in a dropdown box

Post by sahil505 »

Hey, I'm almost done with smilies in a dropdown. Might need a little bit of help from you all in finishing it up.

But for the code that I have written, what should I do next?

User avatar
JimA
Former Team Member
Posts: 66
Joined: Sun Aug 24, 2008 2:29 pm

Re: [RFC] Smilies in a dropdown box

Post by JimA »

sahil505 wrote: Mon Mar 13, 2017 7:53 pm Hey, I'm almost done with smilies in a dropdown. Might need a little bit of help from you all in finishing it up.

But for the code that I have written, what should I do next?
You can create a pull request against the phpBB repository for the ticket you created (PHPBB3-15109) when you're done.
The developers can then see your implementation and provide feedback on it.
Image Jim Mossing Holsteyn - Moderator Team Member
Knowledge Base | Documentation | Board rules

No support here on Area51, please visit the Support forums over at phpBB.com

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 968
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Smilies in a dropdown box

Post by hanakin »

not to steal the topic but its slightly related to the smiles, do we or should we eliminate them in the new theme? with the advent of emojis are smiles still relavent? possibly add something like https://github.com/diy/jquery-emojiarea instead? and change the current code we use for the current smiles to populate the emoji equivalents.
Donations welcome via Paypal Image

Post Reply