PHPBB3-15121: Adding tooltip

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
jajodiaraghav
Registered User
Posts: 4
Joined: Mon Mar 27, 2017 6:14 am

PHPBB3-15121: Adding tooltip

Post by jajodiaraghav » Mon Mar 27, 2017 6:27 am

While working n this issue: https://tracker.phpbb.com/browse/PHPBB3-15121
I want to add title attribute here: https://tracker.phpbb.com/secure/attach ... shot-1.png
So i added strings here: https://github.com/phpbb/phpbb/blob/mas ... en/ucp.php
And the title attr here: https://github.com/phpbb/phpbb/blob/mas ... er.html#L8

But in order to access the added string here https://github.com/phpbb/phpbb/blob/mas ... e.php#L275,
i guess will i have to add it to phpbb_modules table in the database.
See: https://github.com/phpbb/phpbb/blob/mas ... le.php#L95

Can anyone tell me how to do that?

User avatar
RMcGirr83
Registered User
Posts: 357
Joined: Fri Mar 09, 2007 1:51 am
Contact:

Re: PHPBB3-15121: Adding tooltip

Post by RMcGirr83 » Tue Mar 28, 2017 1:00 pm

I don't think your original PR is going to fly.
Do not hire Christian Bullock he won't finish the job and will keep your money

jajodiaraghav
Registered User
Posts: 4
Joined: Mon Mar 27, 2017 6:14 am

Re: PHPBB3-15121: Adding tooltip

Post by jajodiaraghav » Wed Mar 29, 2017 3:26 pm

I am sorry I didn't get you. Am i doing it wrong?

User avatar
RMcGirr83
Registered User
Posts: 357
Joined: Fri Mar 09, 2007 1:51 am
Contact:

Re: PHPBB3-15121: Adding tooltip

Post by RMcGirr83 » Sat Apr 01, 2017 12:34 pm

No you aren't getting it wrong, read the comments in the PR's you've made on the tracker as well as at github.
Do not hire Christian Bullock he won't finish the job and will keep your money

Post Reply