PHPBB3-14844 - BBcode on style inherit from prosilver

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
skouat
Registered User
Posts: 13
Joined: Tue Mar 01, 2011 11:19 pm

Re: BBcode and forum description on style inherit from prosilver

Post by skouat » Mon Oct 31, 2016 7:02 pm

Hi,

Same things for italic
in bbcode.html

Code: Select all

<!-- BEGIN i_open --><em><!-- END i_open -->
<!-- BEGIN i_close --></em><!-- END i_close -->
in bbcode.php

Code: Select all

'i_open'	=> '<span style="font-style: italic">',
'i_close'	=> '</span>',

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: BBcode and forum description on style inherit from prosilver

Post by DavidIQ » Mon Oct 31, 2016 7:09 pm

Neither file was changed in 3.2. Perhaps if the problem is with styles inheriting from prosilver then those styles should have their own bbcode.html? This could just be considered a bug and needs a ticket in the tracker since I don't know why we would replace "B" and "I" BBCodes one way in bbcode.php and a different way in bbcode.html. They should probably match.
Image

Jester-fr
Registered User
Posts: 6
Joined: Sun Oct 30, 2016 2:19 pm

Re: BBcode and forum description on style inherit from prosilver

Post by Jester-fr » Mon Oct 31, 2016 7:14 pm

Yep ! They must match for "b" and "i" in bbcode.html. Changing it on prosilver and bug is solved for any prosilver inherit styles.

cabot
Registered User
Posts: 8
Joined: Sun Jun 02, 2013 11:15 am

Re: BBcode and forum description on style inherit from prosilver

Post by cabot » Mon Oct 31, 2016 7:22 pm

The best practice should be the use of the CSS (as it is in bbcode.php) in order not to depend of the tag display rendering.

And it would be possible, for the next update 3.1, to modify prosilver file as you said in your first post :

Code: Select all

<!-- BEGIN b_open --><span style="font-weight: bold;"><!-- END b_open -->
<!-- BEGIN b_close --></span><!-- END b_close -->

skouat
Registered User
Posts: 13
Joined: Tue Mar 01, 2011 11:19 pm

Re: BBcode and forum description on style inherit from prosilver

Post by skouat » Tue Nov 01, 2016 12:10 pm


User avatar
hanakin Online
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: BBcode and forum description on style inherit from prosilver

Post by hanakin » Tue Nov 01, 2016 12:21 pm

Not sure why bbcode.php ever returned any html it shouldn't it should just return the code from bbcode.html there should never be any html in the core. That's a larger refactor though for 3.3.

skouat
Registered User
Posts: 13
Joined: Tue Mar 01, 2011 11:19 pm

Re: BBcode and forum description on style inherit from prosilver

Post by skouat » Tue Nov 01, 2016 12:45 pm

@hanakin:
It's the case when we used an inherited style. bbcode.php returns the code from bbcode.html. But the tag in the html file is not valid.
Last edited by skouat on Tue Nov 01, 2016 1:03 pm, edited 1 time in total.

cabot
Registered User
Posts: 8
Joined: Sun Jun 02, 2013 11:15 am

Re: BBcode and forum description on style inherit from prosilver

Post by cabot » Tue Nov 01, 2016 12:53 pm

Perhaps would it related to template bietfield?
I ask because I do not understand English well enough so I have not been able to understand the operation described in the article.

User avatar
hanakin Online
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: BBcode and forum description on style inherit from prosilver

Post by hanakin » Tue Nov 01, 2016 1:33 pm

if the bbcode.html is working for all cases then as I said the quick fix will be to just hardcode the styles to both the b & i codes in that file for now and fix it properly in 3.3. If its not and is something related to bbcode.php then thats another story

Also keep in mind 3.2 was rewritten for twig!!!
Nicofuma wrote: poke

Jester-fr
Registered User
Posts: 6
Joined: Sun Oct 30, 2016 2:19 pm

Re: PHPBB3-14844 - BBcode on style inherit from prosilver

Post by Jester-fr » Tue Nov 01, 2016 4:12 pm

A tracker ticket is opened (PHPBB3-14844).

Topic to move on viewforum.php?f=126 ?

Post Reply