New Style for phpBB 3.3 ?

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB's style.
Forum rules
Please do not post support questions regarding installing, updating, or upgrading phpBB or modifying styles of released phpBB versions. If you need support for phpBB please visit the Support Forums on phpbb.com.

If you have questions regarding creating styles please post in Styles Support & Discussion to receive proper guidance from our staff and community.
Locked
User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: New Style for phpBB 3.3 ?

Post by Louis7777 » Sun Sep 18, 2016 2:50 pm

hanakin wrote:
Fri Sep 16, 2016 9:49 am
This is actually closer to the implementation we would go with

Code: Select all

<a class="menu-item" href="#" title="Faq"">
    <svg class="icon">
        <use xlink:href="#faq"></use>
        <span class="hide-mobile">Faq</span>
    </svg>
</a>
Or even better, something like this:

Code: Select all

<svg class="icon" role="img" title="Faq">
        <use xlink:href="external.svg#icon-faq" />
</svg>
And an Internet Explorer fallback if you may:

Code: Select all

/MSIE|Trident/.test(navigator.userAgent) && document.addEventListener('DOMContentLoaded', function () {
  [].forEach.call(document.querySelectorAll('svg'), function (svg) {
    var use = svg.querySelector('use'); 

    if (use) {
      var object = document.createElement('object');
      object.data = use.getAttribute('xlink:href');
      object.className = svg.getAttribute('class');
      svg.parentNode.replaceChild(object, svg);
    }
  });
});

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: New Style for phpBB 3.3 ?

Post by hanakin » Sun Sep 18, 2016 3:47 pm

no fallback is needed for IE... Also there is no difference in our code other than I provided a label

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: New Style for phpBB 3.3 ?

Post by Louis7777 » Sun Sep 18, 2016 4:02 pm

hanakin wrote:
Sun Sep 18, 2016 3:47 pm
no fallback is needed for IE... Also there is no difference in our code other than I provided a label
http://caniuse.com/#feat=svg

It is needed if you want to use an external svg file rather than inlining the code.

That's the best way to do it. A single small .svg sprite, external, that will be cached.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: New Style for phpBB 3.3 ?

Post by hanakin » Sun Sep 18, 2016 4:07 pm

external svg are highly problematic still even with js. We will probably opt for head loaded which is way more less problematic and thats one or two less server requests

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: New Style for phpBB 3.3 ?

Post by Louis7777 » Sun Sep 18, 2016 4:11 pm

hanakin wrote:
Sun Sep 18, 2016 4:07 pm
external svg are highly problematic still even with js. We will probably opt for head loaded which is way more less problematic and thats one or two less server requests
I don't see any other problem other than a couple with IE 9-11 ?

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: New Style for phpBB 3.3 ?

Post by hanakin » Sun Sep 18, 2016 5:18 pm

all the browsers have inconsistencies with external use or at least when I was working on the imageset pr they did. Especially when you get into styling and altering them.

Plus as I said if you can internalize the code for the images to the html page then you are reducing the number of requests made and its actually not that much overhead in file size for the html files which benefit more from caching

User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: New Style for phpBB 3.3 ?

Post by CarpCharacin » Tue Sep 20, 2016 9:18 pm

Will subblue help create the new style?

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 790
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: New Style for phpBB 3.3 ?

Post by hanakin » Tue Sep 20, 2016 10:34 pm

prosilver was created in 2007, and subblue has long moved on. This is a project the current team and any members of these forums will be contributing to ;)

User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: New Style for phpBB 3.3 ?

Post by CarpCharacin » Tue Sep 20, 2016 10:41 pm

Prosilver had actually been in the making since 2004 https://www.phpbb.com/development/prosilver/. I really like prosilver. What colors will the new style be? I think that we should keep the info panel on the right side.

User avatar
mrgtb
Registered User
Posts: 217
Joined: Wed Nov 28, 2007 10:09 pm

Re: New Style for phpBB 3.3 ?

Post by mrgtb » Thu Sep 22, 2016 2:57 pm

hanakin wrote:
Tue Sep 20, 2016 10:34 pm
and subblue has long moved on.
Did subBlue also create SubSilver theme

Locked