[RFC] Post Revisions

[Dog Cow]

Here are stats pulled from a phpBB 2 forum that I host. The forum is very conversational (read: completely non-technical) and it has 586,662 posts as of this writing.

98% of posts were never edited.

Code: Select all

SELECT COUNT(post_id) as total_posts, post_edit_count, (SELECT COUNT(post_id) / (SELECT COUNT(*) FROM phpbb_posts) * 100) as percentage FROM phpbb_posts GROUP BY post_edit_count
LIMIT 25

total_posts     post_edit_count   percentage
577092          0                 98.3687
6354            1                 1.0831
1031            2                 0.1757
479             3                 0.0816
307             4                 0.0523
216             5                 0.0368
155             6                 0.0264
136             7                 0.0232
118             8                 0.0201
76              9                 0.0130
84              10                0.0143
65              11                0.0111
57              12                0.0097
39              13                0.0066
40              14                0.0068
34              15                0.0058
27              16                0.0046
33              17                0.0056
22              18                0.0038
15              19                0.0026
15              20                0.0026
22              21                0.0038
16              22                0.0027
16              23                0.0027
12              24                0.0020

I also have a smaller forum with less than 200,000 posts wherein 99.8% of the posts have never been edited. In fact, I use this to my advantage as the generated HTML output from parsing BBCodes and smileys and whatever else is cached and served directly instead of parsing the post in viewtopic every time.

[EXreaction]

What's the status of this?

[imkingdavid]

Well it was waiting for the controller stuff to get merged. Now I've begun the process of adapting the current implementation into a controller class. But with finals and other stuff going on right now I have not had a lot of time. But I am working on it.

[EXreaction]

Sounds good to me, when do you have finals? I do in about a week and a half.

[imkingdavid]

They're spread over this week and next week.

[EXreaction]

Well good luck

[aleha]

What's the status of this RFC? Are we gonna see it in 3.1?
I can see that there is activity in github.

Btw this is a very good addition!

[imkingdavid]

It's mostly done, but it's lacking in testers and code reviewers. I have also been busy with other things and haven't been able to focus on it recently.

Assuming we get people to thoroughly test functionality and provide feedback, we can move forward a little more quickly.

I'm not sure how realistic it would be for this to make it into 3.1.If it's done prior to 3.1-beta1, I assume it can be merged, but nickvergessen is release manager so he gets the final say. Because any new feature could potentially introduce several unforeseen bugs, it may be more realistic to wait for 3.2. But I can't say for sure.

[Master_Cylinder]

I assume that the admins will be able to enable/disable this, right? I don't want users editing other users posts, ever.

[imkingdavid]

I assume that the admins will be able to enable/disable this, right? I don't want users editing other users posts, ever.

Regarding "users editing other users posts" there is an option that can be disabled altogether that lets you choose whether to make a post a "wiki-style" post. In that case a post would be editable by other users, but only those with the right permission. This option is completely disabled by default. If enabled, it adds an option on the posting screen above "Disable BBCode" below the message box that lets the author make the post a wiki-style post.

However, that is not the main functionality provided by this feature. The main functionality is simply to keep track of all changes made to a post and provide a way to restore an older version if needed, and view what changes were made any by whom.