Ticket: http://tracker.phpbb.com/browse/PHPBB3-11795
PR: https://github.com/phpbb/phpbb3/pull/1666
Found several bugs while working in this issue
[RFC] Get rid of JavaScript in HTML code
Re: [RFC] Get rid of JavaScript in HTML code
if we are finally going to do this can we possibly consolidate all the js files into a sub folder to clean things up a little templates/js/... or in the root of the prosilver folder even better, might be its own rfc after all is said and done, but worth mentioning here
Re: [RFC] Get rid of JavaScript in HTML code
Definitely. There are too many small js files that could be consolidated in one big file and triggered via data attributes on document load.
Formerly known as CyberAlien.
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Free phpBB styles | Premium responsive XenForo styles | Iconify - modern open source replacement for glyph fonts
Re: [RFC] Get rid of JavaScript in HTML code
I should correct myself. When I said "Twig can escape new lines in attributes" what I really meant was "Twig can escape attributes". Does Twig escape new lines? I've checked with the W3 Validator and it seems that new lines are valid in attribute values. As long as quotes get escaped, you're in the clear.
- NORDLANDVOLK
- Registered User
- Posts: 44
- Joined: Thu Oct 14, 2010 8:14 pm
- Location: Tracia
Re: [RFC] Get rid of JavaScript in HTML code
data-attributes is valid in HTML5 as a new furure.
So with other words Twig dont see the new data-attributes?
I think is a good idea to have js file in one big file just like a library.
So with other words Twig dont see the new data-attributes?
I think is a good idea to have js file in one big file just like a library.
+1.Arty wrote:Definitely. There are too many small js files that could be consolidated in one big file and triggered via data attributes on document load.
sorry for my bad english