Remove Quote and Edit button when topic is lock

[Jessica.]

I agree with graying out the buttons.

[Pico88]

We can achive proper effect by replacing:

Code: Select all

<ul class="profile-icons">

with

Code: Select all

<ul class="profile-icons"<!-- IF S_IS_LOCKED --> style="opacity: 0.3;"<!-- ENDIF -->>

[EXreaction]

A CSS class should be used

[Pico88]

Well, some style parts are not in css class For example <!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->

[imkingdavid]

Well, some style parts are not in css class For example <!-- IF postrow.S_POST_HIDDEN --> style="display: none;"<!-- ENDIF -->

Just because some things currently are done one way doesn't mean we should do the the same thing for new code. Bad existing code is no excuse for bad new code.

We also need to add a title attribute to explain that the topic locked that that operation is unavailable.

Would someone be willing to do a mockup and get screenshots of how this will look?

[A_Jelly_Doughnut]

Here is what it looks like with 50% opacity, in Fx 23.

Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.

EDIT: ticket for this: http://tracker.phpbb.com/browse/PHPBB3-11766

[Pony99CA]

Here is what it looks like with 50% opacity, in Fx 23.

It looks good, but it would useful to see that paired with the unlocked verson in the same attachment for comparison.

Should the buttons be grey for moderators as well? I think not, and if folks agree I will change the implementation to match.

If Moderators have to unlock the topic first, then their buttons should be grayed out, too. If Moderators can Post or Edit without unlocking, then they shouldn't be grayed.

Oh, and this should probably also apply to the Delete (X) button, too.

Steve

[A_Jelly_Doughnut]

It does apply to delete, as you can see in the screenshot (if not, this may not be the right effect!)

Moderators can click the greyed button and edit/delete/quote, given appropriate moderator permissions.

Branch is here if anyone wishes to comment: https://github.com/jellydoughnut/phpbb3 ... cket/11766