Pull Request testing on Bamboo

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.
Post Reply
User avatar
Noxwizard
Support Team Leader
Support Team Leader
Posts: 135
Joined: Sun Dec 18, 2005 5:44 pm
Location: Texas
Contact:

Pull Request testing on Bamboo

Post by Noxwizard » Wed Jul 31, 2013 10:48 pm

Our continuous integration server, Bamboo, now tests Pull Requests from Github when they are created or updated. This can be useful if there are a lot of other builds in the queue on Travis. You can view the recent builds here: https://bamboo.phpbb.com/browse/PHPBB3-PR We do only have one worker performing these tests, so if you see either of the Development or Olympus plans running, expect to wait 1.5 hours for those to finish. Additionally, the builds will be listed on the "Builds" tab of your JIRA ticket.

Pull Requests can also be tested against Microsoft's SQL Server 2012 using phpBB's MSSQL Native driver: https://bamboo.phpbb.com/browse/PHPBB3-MSSQLNATIVE

Developers can manually run a PR on either plan by using the Run button and choosing "Run customised." To specify the PR to test, click "Override a variable" and then enter the pull request number in the box.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Pull Request testing on Bamboo

Post by imkingdavid » Thu Aug 01, 2013 3:41 am

Good to know. Thanks for the info!
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Pull Request testing on Bamboo

Post by DavidIQ » Thu Aug 01, 2013 2:48 pm

Will both build definitions (non-MSSQL and MSSQL) run at the same time?
Image

User avatar
Noxwizard
Support Team Leader
Support Team Leader
Posts: 135
Joined: Sun Dec 18, 2005 5:44 pm
Location: Texas
Contact:

Re: Pull Request testing on Bamboo

Post by Noxwizard » Thu Aug 01, 2013 3:55 pm

MSSQL builds must be triggered manually at the moment since it has failing tests. It runs its tests on a separate worker, so you can run it at the same time as other builds.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Pull Request testing on Bamboo

Post by bantu » Thu Aug 01, 2013 4:40 pm

Excellent work. Thanks. :-)

jack.tang
Registered User
Posts: 1
Joined: Wed Mar 12, 2014 11:32 am

Re: Pull Request testing on Bamboo

Post by jack.tang » Wed Mar 12, 2014 11:36 am

Hi,

Would you mind tell me how you made it happen? Some of my engineers are trying to do the same integration with our bamboo and they are not sure what exactly they'll need to do. It will be very helpful if you could give some suggestions.

User avatar
Noxwizard
Support Team Leader
Support Team Leader
Posts: 135
Joined: Sun Dec 18, 2005 5:44 pm
Location: Texas
Contact:

Re: Pull Request testing on Bamboo

Post by Noxwizard » Sat Mar 15, 2014 4:14 pm

After the normal source code checkout, have another script switch to the merge branch:

Code: Select all

git remote set-url origin "https://github.com/phpbb/phpbb.git"
git fetch origin +refs/pull/${bamboo.PRnumber}/merge
git checkout FETCH_HEAD
Origin points to a cached copy of the repo made by Bamboo, so you have to reset it to get access to the rest of the refspace.

The plan has a custom variable assigned to it called PRnumber.

There's a webhook configured in Github to call a script on our server which uses the Bamboo REST API to kick off a build on our PR plan and sets up the custom variable.

bryan.stephens
Registered User
Posts: 1
Joined: Tue Apr 22, 2014 9:26 pm

Re: Pull Request testing on Bamboo

Post by bryan.stephens » Tue Apr 22, 2014 9:31 pm

Hey Noxwizard,

We were looking to do something very similar with our bamboo instance in an effort to move toward Continuous Delivery, would you be willing to share the scripts you have created to make this possible in bamboo?

Thanks!

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: Pull Request testing on Bamboo

Post by Marc » Sat Mar 11, 2017 6:04 pm

Bamboo has been taken offline due to urgent maintenance being necessary. We'll post an update once it's back online.

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: Pull Request testing on Bamboo

Post by Marc » Sun Nov 05, 2017 11:45 am

Bamboo has been back up for quite a while again. I've taken the liberty to also fix the "nightly" builds of phpBB that are linked to on the Area51 homepage:
http://area51.phpbb.com/

The current 3.2.x and master builds can be found respectively at:

Post Reply