[RFC|Merged] Delete "Misc" tab of forum based permissions + move items

[Oleg]

Testing https://github.com/phpbb/phpbb3/pull/946 I noticed that the misc tab does not really need to exist.

I would propose moving "can search forum" to "actions" tab and everything else to "post" tab.

While writing this RFC I further noticed that some of the items on "post" tab really should be under "actions", and subsequently "actions" should become the first/default tab displayed. And then I looked at "content" tab, it's also a mess.

I would suggest the following categorization and ordering:

1. "Actions" tab:

can see forum
can read forum
can search forum
can subscribe forum
can print topics
can email topics
can bump topics
can lock own topics
can download files
can report posts

2. "Post" tab:

can start new topics
can post stickies
can post announcements
can reply to topics
can edit own posts
can delete own posts (? - actions?)

3. "Content" tab:

can attach files
can use topic/post icons
can use bbcode
can use flash bbcode
can use img bbcode
can use signatures
can use smilies

4. "Polls" tab (unchanged):

can create polls
can vote in polls
can change existing vote

If this RFC is approved I won't be implementing it but I will merge a PR doing so.

[EXreaction]

Do the tabs show if there are no permissions under them? If not, I'd recommend leaving the tab for modifications.

[Jacob]

What about the following?:

1. "Forum" tab:

can see forum
can read forum
can search forum
can subscribe forum

2. "Topic" tab:

can start new topics
can post stickies
can post announcements
can reply to topics
can bump topics
can lock own topics
can print topics
can email topics

3. "Post" tab:

can edit own posts
can delete own posts
can report posts

4. "Content" tab:

can download files
can attach files
can use topic/post icons
can use bbcode
can use flash bbcode
can use img bbcode
can use signatures
can use smilies

5. "Polls" tab (unchanged):

can create polls
can vote in polls
can change existing vote

[Oleg]

This is more of an object-centric proposal, whereas mine was more action-centric. Right now I favor the action-centric one (the one in my post).

[Pony99CA]

Sounds reasonable, but not a big deal. However, if it gets my Logical Permission Ordering RFC implemented, too, I'm more in favor of it.

However, neither proposal showed where the MIsc items were positioned (other than Can search forum). Where would Can ignore flood limit, Can post without approval and Increment post counter be placed on the Post tab?

Now that I think about it, I also wonder why Increment post counter is a user/group permission at all instead of a forum option. What use case is there for allowing Group A to have their post counts increase when posting to a forum while not allowing Group B to have theirs increase? It makes more work to turn it off on a forum-specific basis if you have to do it group by group. (You could use a role, but then you have to create or edit that role.)

Steve

[Oleg]

I did not see these permissions in my UI, this is why I did not include them. I would either put them on the bottom of post tab after everything else, or after post stickies/announcements.

From your RFC it sounds like getting another ordering at all (doesn't matter what it is as long as it's externally specified, e.g. via an RFC such as this one) is going to be the difficult part.

[Pony99CA]

From your RFC it sounds like getting another ordering at all (doesn't matter what it is as long as it's externally specified, e.g. via an RFC such as this one) is going to be the difficult part.

Your suggested order was pretty reasonable for the user forum permissions. We just need the rest of the permissions to be ordered logically, too.

Steve

[RMcGirr83]

I have this mostly done but not sure if the RFC is accepted or not.

[MichaelC]

I have this mostly done but not sure if the RFC is accepted or not.

RFCs don't get accepted anymore, its more a case of finding consensus in the RFC, if a developer agrees a topic leans towards merging it & the patch is good then they will do so.

[RMcGirr83]

http://tracker.phpbb.com/browse/PHPBB3-11156

Hope I did that correctly.