[RFC|Merged] Template Events
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] Template Events
Yes, is anyone working on this or planning to work on this?
Re: [RFC] Template Events
No promises at this time.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] Template Events
imkingdavid, were you going to work on this? That was my understanding, if not I can take a look at it.
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Template Events
To be honest, I wouldn't know where to start. No offense to Oleg but his PR appears to be a mess with quite a bit of debugging code and such. I can see what I can do, but you're welcome to take a stab as well.EXreaction wrote:imkingdavid, were you going to work on this? That was my understanding, if not I can take a look at it.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] Template Events
I'm working on this. I have the resource locator working properly and everything in the core, but I'm having an issue with the test case.
The problem is that in the test case, for some reason, the "trivial" extension that is used does not come up under the list of roots in the resource locator. I've been trying to figure out how the extension directories are added to that list of roots, but I cannot find anything that assigns them, anyone have any hints?
I've created a new PR: https://github.com/phpbb/phpbb3/pull/1010
The problem is that in the test case, for some reason, the "trivial" extension that is used does not come up under the list of roots in the resource locator. I've been trying to figure out how the extension directories are added to that list of roots, but I cannot find anything that assigns them, anyone have any hints?
I've created a new PR: https://github.com/phpbb/phpbb3/pull/1010
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] Template Events
Actually, it's far more complicated than that.
I believe the main issue I'm getting now is due to the finder in the extensions, since the style path is not in the phpbb root path. I'm working on it, but it's a lot to go through and figure out how to appropriately fix...
I believe the main issue I'm getting now is due to the finder in the extensions, since the style path is not in the phpbb root path. I'm working on it, but it's a lot to go through and figure out how to appropriately fix...
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] Template Events
I believe I've solved it now and I think template events are ready for merging: https://github.com/phpbb/phpbb3/pull/1010
- imkingdavid
- Registered User
- Posts: 1050
- Joined: Thu Jul 30, 2009 12:06 pm
Re: [RFC] Template Events
I have reviewed it and it looks fine to me other than the items I pointed out. I still need to test it, but IMO if it works it can be merged.
- EXreaction
- Registered User
- Posts: 1555
- Joined: Sat Sep 10, 2005 2:15 am
Re: [RFC] Template Events
Which items are you specifically referring to?
EDIT: Nevermind, I see on Github, I thought you were talking about this thread.
EDIT: Nevermind, I see on Github, I thought you were talking about this thread.
Re: [RFC] Template Events
Tests now pass therefore either additional test cases need to be devised or the pull request should be merged.
https://github.com/phpbb/phpbb3/pull/764
https://github.com/phpbb/phpbb3/pull/764