[RFC] Logical Permission Ordering

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

[RFC] Logical Permission Ordering

Post by Pony99CA »

I started the Permission Order topic on phpBB.com because the order of permissions in the ACP made no sense to me. As explained there, they're ordered alphabetically by their internal name, which won't make sense to most people.

For example, here are the forum advanced permissions for posting:
Can post announcements
Can use topic/post icons
Can see forum
Can start new topics
Can read forum
Can reply to topics
Can post stickies
Wouldn't it make more sense to have them like this:
Can see forum
Can read forum
Can start new topics
Can reply to topics
Can post announcements
Can post stickies
Can use topic/post icons
To post, you must first be able to see the forum, then be able to read it. You first must have a topic, then be able to reply. Announcements, stickies and icons are modifiers and so should be last, although they could be between Can start new topics and Can reply to topics because they apply to the first post (in general).

Or consider the content permissions:
Can attach files
Can use BBCode
Can download files
Can use [flash] BBCode tag
Can use [img] BBCode tag
Can use signatures
Can use smilies
Wouldn't the following make more sense:
Can attach files
Can download files
Can use BBCode
Can use [flash] BBCode tag
Can use [img] BBCode tag
Can use smilies
Can use signatures
You can't download unless a file is attached, all of the BBCode items are grouped together and signatures are the last thing on a post. (Maybe you'd put attachments last, as those are at the bottom of the posting box.)

I think that rearranging these and the other permissions would help make permissions a bit easier to find and understand.

If you disagree with my suggested ordering, please provide your own for discussion instead of just giving a -1; a -1 should only be given if the whole idea is bad. ;) Ideally, we'll have suggested orderings for all permissions in here.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Logical Permission Ordering

Post by brunoais »

I also think your RFC makes sense. Not that I even needed it in that order but It would probably be better if it was.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Logical Permission Ordering

Post by imkingdavid »

IMO announcements would come after stickies because announcements are one step above stickies in visibility. The way topics are currently ordered are Announcements at the top, Stickies beneath them, and normal topics after that. So the permissions should be set up in reverse of that: topics -> stickies -> announcements.

-----
As for implementation...

There is currently a commented out block of code in includes/acp/auth.php on line 1116 down to 1130. When uncommented, permissions are ordered as they appear in the language file. The comment says that uncommenting it slows execution down, but I did not see a significant difference in load time when I uncommented the code and the memory consumption remained consistent regardless.

IMO, the way to go is to uncomment that section and then reorder the language/en/permissions_phpbb.php array to the order we want.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
Vinny
Style Customisations
Style Customisations
Posts: 129
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] Logical Permission Ordering

Post by Vinny »

+1
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Logical Permission Ordering

Post by MichaelC »

+1 but i think implementation might be easier with extensions if we have a weighting system (of say 100) is introduced, then mods can choose numbers inbetween the default ones. If they clash with another extension then its not the end of the world, the two with the same weight would fall back to displaying in alphabetical order.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Logical Permission Ordering

Post by Pony99CA »

I like the idea of being able to support extensions with weighting,

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Logical Permission Ordering

Post by EXreaction »

Can use topic/post icons should probably be under content as well.
User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: [RFC] Logical Permission Ordering

Post by Jessica. »

+1
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Logical Permission Ordering

Post by brunoais »

imkingdavid wrote:IMO announcements would come after stickies because announcements are one step above stickies in visibility. The way topics are currently ordered are Announcements at the top, Stickies beneath them, and normal topics after that. So the permissions should be set up in reverse of that: topics -> stickies -> announcements.
I think more as:

Code: Select all

           topics
             |
stickies <-    ->  announcements
Stickies are at the same level as announcements. You don't need permission to watch announcements in order to watch stickies and vice-versa
Post Reply