[RFC] Coding guidelines: var keyword in js per line

[Oleg]

Each line in JS that declares variables should have its own var keyword, in order for diffs to not change irrelevant lines.

See also: http://benalman.com/news/2012/05/multip ... avascript/

[Senky]

+1

[Erik Frèrejean]

Kinda surprised that this isn't already the case.

[callumacrae]

I also suggest that in the name of a nicer diff, we use the following syntax for objects:

Code: Select all

var obj = {};
obj.foo = 'a';
obj.bar = 'b';

In fact, pretty much all of the relevant arguments can be applied to objects.

Let's take it a step further. I reckon that we should use the following for arrays:

Code: Select all

var ary = [];
ary.push('a');
ary.push('b');

It's only a few extra characters, and it makes it way easier to reorder array entries, no?


Seriously though, I am against this change. It isn't exactly DRY, is it?

What I wouldn't be against is the change suggested at the end of the article:

Code: Select all

var foo, bar;
foo = 1;
bar = 2;

[Erik Frèrejean]

What I wouldn't be against is the change suggested at the end of the article:

Code: Select all

var foo, bar;
foo = 1;
bar = 2;

That really doesn't help a lot, the first line still changes for no reason. That last example shows completely different behavior, that speaks of the difference whether a variable gets an assignment or not.

[wGEric]

You could always use JS Lint or JS Hint to catch when a variable would become global.

I also suggest that in the name of a nicer diff, we use the following syntax for objects:

Code: Select all

var obj = {};
obj.foo = 'a';
obj.bar = 'b';

In fact, pretty much all of the relevant arguments can be applied to objects.

Let's take it a step further. I reckon that we should use the following for arrays:

Code: Select all

var ary = [];
ary.push('a');
ary.push('b');

It's only a few extra characters, and it makes it way easier to reorder array entries, no?

This would make Javascript files larger.

Code: Select all

(function() {
var obj = {};
obj.foo = 'a';
obj.bar = 'b';

var ary = [];
ary.push('a');
ary.push('b');
})()

Old version: 115 characters
New version: 77 characters
Saved: 38 (result is 66.9% of original)

Code: Select all

(function(){var a={};a.foo="a",a.bar="b";var b=[];b.push("a"),b.push("b")})()

Code: Select all

(function() {
var obj = {
'foo' : 'a',
'bar' : 'b'
};
var ary = [
'a',
'b'
];
})()

Old version: 91 characters
New version: 51 characters
Saved: 40 (result is 56.0% of original)

Code: Select all

(function(){var a={foo:"a",bar:"b"},b=["a","b"]})()

What I wouldn't be against is the change suggested at the end of the article:

Code: Select all

var foo, bar;
foo = 1;
bar = 2;

The diff would still show two lines being changed and IMO would make it easier to accidentally make global variables.

[callumacrae]

No need to worry about global variables, strict case is enabled and so global variable assignments should throw errors.

[Oleg]

Array and hash initialization is an entirely separate topic and not relevant here.

[callumacrae]

It was also an entirely sarcastic post to demonstrate the absurdity of what you're requesting

[Oleg]

Your sarcastic post failed to make any sort of a relevant point.

I was going to reply to the rest of your post, but:

to demonstrate the absurdity of what you're requesting

I am tired of you spewing assertions such as this, in tone that suggests that you are some kind of authority on the issue you speak about, when most of the time you are either clueless or blatantly wrong. Until you fix this I simply will not be having conversations with you.