[RFC] GeSHi highlighting

[AliasM2K]

Just a suggestion; there is Prettify too...

[brunoais]

I believe that won't be accepted because it works in the client side (js).

[callumacrae]

I believe that won't be accepted because it works in the client side (js).

What's wrong with client-side highlighting?

[Erik Frèrejean]

I say that this is what I'd call a great extension.
I think the overhead of this does not make it worthwhile for the core. Many forums that run phpBB are forums related to coding, right.
I still believe that that is not enough to have such feature in the core.
So, -1 for core. Great as an extension
(technical stuff under this)
This is something very easy to place. This is just something that processes text.
Having that into account, I believe we just need to insert geshi into the BBcode parser (the part before displaying the post).
A nicely placed event will make the extension making simple enugh.

+1

[brunoais]

I believe that won't be accepted because it works in the client side (js).

What's wrong with client-side highlighting?

Does not work for non js users.

[wGEric]

Does not work for non js users.

You could argue that this feature is like AJAX, enhances the user experience but everything still works without it.

[callumacrae]

I wouldn't class syntax highlighting as an essential feature, just an enhancement - it doesn't need to work with JS disabled.

[AliasM2K]

I wouldn't class syntax highlighting as an essential feature, just an enhancement - it doesn't need to work with JS disabled.

Absolutely

[DavidIQ]

+1 for being kept as an extension.

[imkingdavid]

+1 for being kept as an extension.