[RFC|Merged] Pagination as <ul> list

[naderman]

Currently the pagination styling is done by a class called .pagination. The html rendered shows something like this:

Code: Select all

<div class="pagination">
         11 mensajes
          • <a href="#" onclick="jumpto(); return false;" title="Clic para saltar a página…">Página <strong>1</strong> de <strong>2</strong></a> • <span><strong>1</strong><span class="page-sep">, </span><a href="./viewtopic.php?etc">2</a></span>
      </div>

I guess you can see how messy it looks, this is my alternative:

Code: Select all

<div class="pagination">
    <ul>
        <li>11 mensajes</li>
        <li><a href="#" onclick="jumpto(); return false;" title="Clic para saltar a página…"></li>
        <li>Página <strong>1</strong> de <strong>2</strong></a></li>
        <li>1</li>
        <li><a href="./viewtopic.php?etc">2</a></li>
    </ul>
</div>

Or something like that, the point is, the current state looks outdated and not that easy to customize IMO.

TICKET: http://tracker.phpbb.com/browse/PHPBB3-10968

[callumacrae]

+1

[MichaelC]

+1

[brunoais]

+1

[Senky]

+1

[AliasM2K]

+1 of course

[brunoais]

+1

[hanakin]

+1

this was mentioned along with several other mistakes in the backend that produce in proper semantics or render html when they only need to output text in a post I made awhile back

[Meis2M]

and +2

[psoTFX]

I've opened a ticket for this. It's a little different from the op's original proposal but accomplishes the basic requirement. Rendering of pagination moves entirely to the template where the markup is of the (general) form:

Code: Select all

<div class="pagination">
            <ul>
            <!-- BEGIN pagination -->
               <!-- IF pagination.S_IS_PREV -->
               <!-- ELSEIF pagination.S_IS_CURRENT -->
               <li class="active"><span>{pagination.PAGE_NUMBER}</span></li>
               <!-- ELSEIF pagination.S_IS_ELLIPSIS -->
               <li class="ellipsis"><span>{L_ELLIPSIS}</span></li>
               <!-- ELSEIF pagination.S_IS_NEXT -->
               <!-- ELSE -->
               <li><a href="{pagination.PAGE_URL}">{pagination.PAGE_NUMBER}</a></li>
               <!-- ENDIF -->
            <!-- END pagination -->
            </ul>
</div>


This looks a bit "woowah!" - but I think it gives complete control of just what is shown. For example rather than the source deciding whether to show next/previous the style designer can and the form they may take. Likewise the form of any ellipsis, how "current" (active) elements are displayed, etc. Pagination can still be embedded within other blocks, e.g. on viewforum (for multi-page topics), etc. in the process I eliminated the seperate topic_generate_pagination function and merged it with generate_pagination (I did take a couple of liberties but they are just consistent with how things have worked for years). I need to modify the subsilver2 templates then I'll put in a PR.