phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC] Quick Reply only on Last Page

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [RFC] Quick Reply only on Last Page

Postby naderman » Fri May 04, 2012 4:04 pm

As David said, we do not need an option for everything. Let's do exactly what he said. Quick reply always collapsed on every page but the last.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: [RFC] Quick Reply only on Last Page

Postby imkingdavid » Sun Dec 16, 2012 7:46 pm

I thought of this again when I clicked the "First Unread Post" link for a topic, which brought me to the second-to-last page. At the bottom I went to the QR box to reply and then realized that I was not on the last page. Also, in the past, I have replied to a topic in a similar scenario without realizing that I wasn't on the last page and had to go back and edit my post later.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-11274

Here is the PR that uncollapsed the QR: https://github.com/phpbb/phpbb3/pull/660
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 902
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Quick Reply only on Last Page

Postby brunoais » Mon Dec 17, 2012 9:02 am

What? The development of this is stopped?
I thought it was going at a nice speed... (or maybe finished, just not merged into area51)
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Quick Reply only on Last Page

Postby imkingdavid » Mon Dec 17, 2012 2:29 pm

I don't see an existing pull request for this. I don't believe that the development of this ever started, much less that it has stopped.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 902
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Quick Reply only on Last Page

Postby bantu » Mon Dec 17, 2012 3:54 pm

callumacrae wrote:I often reply from another page. How about closed by default on any page that isn't the last?

+1
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
 
Posts: 438
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany

Re: [RFC] Quick Reply only on Last Page

Postby ecwpa » Mon Dec 17, 2012 7:31 pm

I don't know, It seems like the real problem for imkingdavid is noticing if you're on the last page or not, which to me it looks like a design issue with the pagination and not the quick reply.
Sorry for my bad english, still improving.
ecwpa
Registered User
 
Posts: 169
Joined: Mon Jan 24, 2005 2:10 am

Re: [RFC] Quick Reply only on Last Page

Postby brunoais » Mon Dec 17, 2012 7:50 pm

callumacrae wrote:I often reply from another page. How about closed by default on any page that isn't the last?

+1
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Quick Reply only on Last Page

Postby nickvergessen » Wed Dec 19, 2012 10:10 pm

ecwpa wrote:I don't know, It seems like the real problem for imkingdavid is noticing if you're on the last page or not, which to me it looks like a design issue with the pagination and not the quick reply.

If that would be the problem, its that QR comes before pagination, while pagination is 10times bigger then the little page icons
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: [RFC] Quick Reply only on Last Page

Postby Pony99CA » Thu Dec 20, 2012 3:46 am

Senky wrote:I think we should keep it as it is, and leave modifications on estensions. I personally would like to see some kind of message notifying me I am not on the last page, not to reply by something that is mentioned in later posts, but I would keep this for extensions...

Maybe moving the pagination area above the Quick Reply box would make it more obvious whether you were on the last page or not.

:lol: I see that Nick said that earlier -- because I didn't realize that I was not on the last page.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.
User avatar
Pony99CA
Registered User
 
Posts: 467
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA

Re: [RFC] Quick Reply only on Last Page

Postby brunoais » Thu Dec 20, 2012 12:50 pm

Pony99CA wrote:
Senky wrote:I think we should keep it as it is, and leave modifications on estensions. I personally would like to see some kind of message notifying me I am not on the last page, not to reply by something that is mentioned in later posts, but I would keep this for extensions...

Maybe moving the pagination area above the Quick Reply box would make it more obvious whether you were on the last page or not.

That's also what has already been proposed... And I agree.
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Previous Next

Return to [3.x] RFCs

Who is online

Users browsing this forum: No registered users and 12 guests