[RFC] AJAX Quick Edit

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: [RFC] AJAX Quick Edit

Post by Senky » Wed Apr 11, 2012 7:21 pm

imkingdavid wrote:...I'm cool with the animation as it is.
Maybe we could try slideToggle or fadeIn/fadeOut effects - it looks better for me...more professional I would say...

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Wed Apr 11, 2012 9:48 pm

Again, this is not perfect. Instead of that animation a loading image should probably look best. FadeIn didn't work really good as far as I remember. The quickedit button was just added as this was meant as an implementation into phpBB 3.0 and I didn't want to replace the function of the normal edit button.
Changing the button from "Advanced Edit" to "Full Editor & Preview" shouldn't be a problem at all.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] AJAX Quick Edit

Post by DavidIQ » Thu Apr 12, 2012 2:45 am

FadeIn/Out does some funky things to text on the page in the fade section so I'd not use it for this.
Image

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] AJAX Quick Edit

Post by brunoais » Thu Apr 12, 2012 6:59 am

For the preview, we could use a nice modal window (with the result :)) just above the textarea that uses the space between the textarea and the top of the window. If the text is too big, there can be scrolling.
This is probably also less server intensive.
Whatcha think?

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Thu Apr 12, 2012 11:42 am

If someone wants to see a preview it's IMHO not a quickedit anymore.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] AJAX Quick Edit

Post by brunoais » Thu Apr 12, 2012 12:26 pm

^ I'm ok with that :)

wGEric
Registered User
Posts: 521
Joined: Wed Jun 11, 2003 2:07 am
Contact:

Re: [RFC] AJAX Quick Edit

Post by wGEric » Thu Apr 12, 2012 4:27 pm

DavidIQ wrote:Animations are good to let the user know something's going on. It confuses me when I do something on a website and there is something actually going on in the background but since there is no indication of that I start making assumptions like "the website's broken", "the form didn't work", etc. and then I try again. Perhaps a different indicator would be better?
Isn't an edit box showing and disappearing enough indication that something is happening? Showing the edit box should be instant. Adding a loading indicator just to show the edit box makes no sense. It doesn't need to load anything. Saving the edit can have a loading indicator. Although you could probably get away with changing the contents of the post instantly and only notifying the user if saving the post failed.
Eric

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Thu Apr 12, 2012 6:36 pm

A few things that need to be decided:
  • Should the edit button in the mcp also have a quick edit function?
  • How about the PM area?
  • Include BBCodes or not?
I'd say don't add BBCodes especially since the quick reply doesn't have bbcodes either.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] AJAX Quick Edit

Post by brunoais » Thu Apr 12, 2012 7:25 pm

marc1706 wrote:A few things that need to be decided:
  • Should the edit button in the mcp also have a quick edit function?
  • How about the PM area?
  • Include BBCodes or not?
  • Hum... It's not bad to have but... Is it useful?
  • My answer is Yes!
  • No. If you want it in your forum use an extension

Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: [RFC] AJAX Quick Edit

Post by Senky » Thu Apr 12, 2012 7:26 pm

IMO:

In MCP - definitelly - moderators need this as much as common users...

PM area - I am not sure, for now, maybe it is enough for pots only... but if it is not such problem to implement it in PMs, why not...

Do not include BBCodes, as you said, they are not included in QR, too...

Post Reply