phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC] Ability to @mention specific users in posts

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [RFC] Ability to @mention specific users in posts

Postby brunoais » Wed Apr 11, 2012 2:23 pm

Senky wrote:@"my nickname"

otherwise it is almost impossible to correctly catch all mentions of multi-word usernames by php parser.

I already have a regex find that is usable with that :). Ready to use.
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Ability to @mention specific users in posts

Postby jsebean » Wed Apr 11, 2012 2:29 pm

I would like to see it implemented with javascript regarding to how Facebook does it. You @ mention someone and then it shows a list of users. With that said, now people would have to think how to implement this in CKEditor if they use it, or what ever rich text editor they use, and what to do if a plain text editor was used (maybe the feature shouldn't work at all if plain text was used?) How is it going to be processed?
-Jonah
Formerly known as jsbean.
User avatar
jsebean
Registered User
 
Posts: 136
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] Ability to @mention specific users in posts

Postby callumacrae » Wed Apr 11, 2012 2:31 pm

jsebean wrote:If there is a wide match you could use the already existing find user system that's already used in PMs and the ACP.

There's a ticket somewhere for improvements to the Find user thing to use AJAX, which I was planning on doing. It could be used for this, too.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 881
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] Ability to @mention specific users in posts

Postby callumacrae » Wed Apr 11, 2012 2:32 pm

jsebean wrote:I would like to see it implemented with javascript regarding to how Facebook does it. You @ mention someone and then it shows a list of users. With that said, now people would have to think how to implement this in CKEditor if they use it, or what ever rich text editor they use, and what to do if a plain text editor was used (maybe the feature shouldn't work at all if plain text was used?) How is it going to be processed?

Facebook doesn't do it like that, it doesn't even have @ anymore.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 881
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] Ability to @mention specific users in posts

Postby jsebean » Wed Apr 11, 2012 2:34 pm

I can tag users in posts in facebook. It doesn't have the @ sign in front but it's the same thing, mentioning a user in a status update, a user gets a notification. You can use @ when trying to mention someone on facebook, the @ will be taken away once you select a name you're tagging.

Of course, phpBB and Facebook isn't the same, but the idea is the close to the same. How would it be implemented though in phpBB?
-Jonah
Formerly known as jsbean.
User avatar
jsebean
Registered User
 
Posts: 136
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] Ability to @mention specific users in posts

Postby AliasM2K » Wed Apr 11, 2012 9:36 pm

Erik Frèrejean wrote:There should be some sort of "notification" box which is used for these kind of notifications. I don't think that the end user should be able to chose, just add a new special box for these kind of notifications.


Something like "Mentions" perhaps?
User avatar
AliasM2K
Registered User
 
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] Ability to @mention specific users in posts

Postby Erik Frèrejean » Thu Apr 12, 2012 4:40 am

AliasM2K wrote:
Erik Frèrejean wrote:There should be some sort of "notification" box which is used for these kind of notifications. I don't think that the end user should be able to chose, just add a new special box for these kind of notifications.


Something like "Mentions" perhaps?

The biggest advantage of making it more generic (i.e. notifications) is that you can utilise it if phpBB down the road needs to sent other notifications and MOD authors can use it as well to send out notifications.
Available on .com
Support Toolkit developer
User avatar
Erik Frèrejean
Registered User
 
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet

Re: [RFC] Ability to @mention specific users in posts

Postby _hsr » Thu Apr 12, 2012 6:45 am

Well, once the "search user should recommend usernames" is finished and merged, we can figure out a way to use the same thing in finding usernames with spaces.

Tagging can also be done in a style similar to the github markup for links, for eg:
Code: Select all
[@user name], you should try this option : blabla or ask [@user2] about it


[@1] [link_to_profile]
[@2] [link_to_profile2]


and the parser should output something like:
user name, you should try this option : blabla or ask user2 about it
There is a text here !
_hsr
Registered User
 
Posts: 42
Joined: Mon Mar 26, 2012 7:06 am

Re: [RFC] Ability to @mention specific users in posts

Postby ecwpa » Fri Apr 13, 2012 3:41 am

callumacrae wrote:Facebook doesn't do it like that, it doesn't even have @ anymore.


It's still there, at least for me:

Image

Image


A "mentions" section separated from pm sounds good to me.
Sorry for my bad english, still improving.
ecwpa
Registered User
 
Posts: 169
Joined: Mon Jan 24, 2005 2:10 am

Re: [RFC] Ability to @mention specific users in posts

Postby *Daniel » Fri Apr 13, 2012 4:01 am

Erik Frèrejean wrote:
brunoais wrote:Personally I wouldn't like to have this kind of PM mixedup with the rest of the PMs, I'd rather have a folder specially made for these warnings. I think you should take that in mind while implementing this feature, don't force the user to receive the PM about this in the inbox, allow him to choose the folder to receive this.

^ that.
There should be some sort of "notification" box which is used for these kind of notifications. I don't think that the end user should be able to chose, just add a new special box for these kind of notifications.



I've created a RFC for the notification issue: viewtopic.php?f=108&t=42829
Oleg wrote:This topic's title takes the prize for most errors per word (3 in 4).
*Daniel
Registered User
 
Posts: 161
Joined: Mon Feb 08, 2010 3:42 am

Previous Next

Return to [3.x] RFCs

Who is online

Users browsing this forum: dhruv.goel92 and 8 guests