phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC|Merged] AJAX

These requests for comments have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.

Re: [RFC|Merged] AJAX

Postby imkingdavid » Sat Mar 31, 2012 2:50 pm

callumacrae wrote:
_hsr wrote:Regarding the quickedit feature, how would it best be implemented, a pop up text editor or an inline version?

I would prefer inline.

+1 Inline is better. Most users don't like pop ups.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 902
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Merged] AJAX

Postby Arty » Sat Mar 31, 2012 3:45 pm

+1 for inline. It makes much more sense and allows to copy/paste parts of other posts for quoting
Formerly known as CyberAlien.
User avatar
Arty
Styles Team
Styles Team
 
Posts: 796
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars

Re: [RFC|Merged] AJAX

Postby victory1 » Sun Apr 01, 2012 12:50 am

+1 for Inline. This is one of the things I complained about in the phpBB is falling Behind topic. The lack of ajax/jquery function for QuickReply. Also, the fact that phpbb does not even come with a QuickEdit without having to install a mod.
victory1
Registered User
 
Posts: 5
Joined: Tue May 17, 2011 2:29 am

Re: [RFC|Merged] AJAX

Postby brunoais » Sun Apr 01, 2012 7:23 am

Inline that reacts when the quote buttons are clicked such that it will append the quote text inside quotes when a quote button is clicked.
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC|Merged] AJAX

Postby DavidIQ » Sun Apr 01, 2012 12:01 pm

Shouldn't quick edit just be a separate RFC?
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 760
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: [RFC|Merged] AJAX

Postby callumacrae » Sun Apr 01, 2012 12:10 pm

DavidIQ wrote:Shouldn't quick edit just be a separate RFC?

It is ;-)
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC|Merged] AJAX

Postby DavidIQ » Sun Apr 01, 2012 12:15 pm

Then why is it being discussed here? ;)
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 760
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: [RFC|Merged] AJAX

Postby Arty » Tue Apr 10, 2012 8:00 pm

Bug: when moving topic via quick mod tools, it shows dialog box asking "Move topic?" with yes and no buttons, without forum select boxes.
Formerly known as CyberAlien.
User avatar
Arty
Styles Team
Styles Team
 
Posts: 796
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars

Re: [RFC|Merged] AJAX

Postby callumacrae » Tue Apr 10, 2012 8:03 pm

Arty wrote:Bug: when moving topic via quick mod tools, it shows dialog box asking "Move topic?" with yes and no buttons, without forum select boxes.

That shouldn't be AJAXified, I'll take a look at that when I fix the others tomorrow.

Other bugs / improvements (I'll forget by tomorrow if I don't note them down):

Not all the mark as read links are AJAXey, specifically "Mark subforums as read" and the ones below the forum listing.

20:16 <@naderman> we should have like some config var that we increment on database
update
20:16 <@naderman> which is appended to all css/js urls
20:17 <@naderman> callumacrae: feel free to implement that if you like
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC|Merged] AJAX

Postby Oleg » Tue Apr 10, 2012 8:04 pm

Bug reports should go in the tracker.

Last time I reported a bug in ajax I could not figure out which ticket should have been used in the "caused by" relationship.
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Previous Next

Return to [3.1/Ascraeus] Merged RFCs

Who is online

Users browsing this forum: No registered users and 10 guests