[RFC] AJAX Quick Edit

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] AJAX Quick Edit

Post by brunoais » Tue Apr 10, 2012 7:13 pm

marc1706 wrote:I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.
WOW *sparkling eyes*!
We have a perfectly complete code. we could use that!

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Tue Apr 10, 2012 7:17 pm

marc1706 wrote:I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.
I don't really like the animation, and I think that it should replace the current edit entirely, but I like it :-)
Made by developers, for developers!
My blog

Senky
Extension Customisations
Extension Customisations
Posts: 283
Joined: Thu Jul 16, 2009 4:41 pm

Re: [RFC] AJAX Quick Edit

Post by Senky » Tue Apr 10, 2012 7:26 pm

callumacrae wrote:...I don't really like the animation...
It is the very last thing I would think of :). Change animation = change 1 line in code ;)

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] AJAX Quick Edit

Post by jsebean » Tue Apr 10, 2012 7:41 pm

I like the animation, to have it not animated it's just not that inviting if you know what I mean. It's nice to have things bare bones but not too bare. I also agree, this should take place of the regular edit feature since there's not really any point in having both. Having both just over complicates things, especially new users. If not, then if you used it as quick edit, the I'd say don't include smilies and subject like it currently is otherwise it would seem pointless. If you replaced the current edit function, you would have to include the subject field as well and smilies.
-Jonah

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Tue Apr 10, 2012 7:59 pm

jsebean wrote:I like the animation, to have it not animated it's just not that inviting if you know what I mean. It's nice to have things bare bones but not too bare. I also agree, this should take place of the regular edit feature since there's not really any point in having both. Having both just over complicates things, especially new users. If not, then if you used it as quick edit, the I'd say don't include smilies and subject like it currently is otherwise it would seem pointless. If you replaced the current edit function, you would have to include the subject field as well and smilies.
If it is animated, I think that it should be something like a fade, not how it is currently done.
Made by developers, for developers!
My blog

User avatar
Marc Online
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Tue Apr 10, 2012 8:05 pm

Well changing the animation would be one of the easier tasks. ;)

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Wed Apr 11, 2012 12:55 am

marc1706 wrote:I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.
Absolutely cool! :D

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] AJAX Quick Edit

Post by imkingdavid » Wed Apr 11, 2012 5:33 pm

marc, For that demo you showed, it looks great. 3 things though:
1. "Advanced Edit" should be "Full Editor" for consistency with QR.
2. Do we want to allow previewing from quick edit? If so, consider doing similar to the current Quick Reply, where it automatically displays a preview when the Full Editor & Preview button is pressed (and does not show preview when the box is empty).
3. Instead of two separate buttons, how about just making the Edit button default to quick edit, and then users can click Full Editor to get to the normal edit screen.

EDIT: And a 4th
4. I'm cool with the animation, but I think most people would expect it to just instantly change without any transition. So perhaps just removing the animation for now? Or we could merge it with animation and let the users tell if they like it or not.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] AJAX Quick Edit

Post by DavidIQ » Wed Apr 11, 2012 5:38 pm

Animations are good to let the user know something's going on. It confuses me when I do something on a website and there is something actually going on in the background but since there is no indication of that I start making assumptions like "the website's broken", "the form didn't work", etc. and then I try again. Perhaps a different indicator would be better?
Image

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] AJAX Quick Edit

Post by imkingdavid » Wed Apr 11, 2012 5:41 pm

We could do a quick loading animation, for like 1 second (you know, the little rotating circle) and then have the editor appear? But like I said, I'm cool with the animation as it is.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply