phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

WYSIWYG Editor/Rich Text Editor

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [RFC] WYSIWYG Editor

Postby callumacrae » Wed Mar 07, 2012 6:20 am

I disagree with defaulting to the source view. I'm thinking of using cookies do that if a user changes it to source view, it is still in source view next time is opened. There will also be a UCP option to disable it entirely.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] WYSIWYG Editor

Postby brunoais » Wed Mar 07, 2012 7:25 am

I think it should be made with default that should be changeable in the UCP.
If the user prefers one mode he can change in the UCP, if he prefers another mode, also change in the UCP.

Another thing, CKEditor is moderately heavy. It should only be loaded if the user wants to.
E.g. Going to the posting page, pressing the quick reply button, etc...
brunoais
Registered User
 
Posts: 627
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] WYSIWYG Editor

Postby wiktor » Wed Mar 07, 2012 3:40 pm

Just wanted to propose something, not sure how similar it is to the results of the conversation in IRC.

Default state:

phpbb_ckeditor_off.png

After clicking on the "Enable rich-text editor" link:

phpbb_ckeditor_on.png


Some thoughts (just my personal opinion):

  • the initial integration may have some bugs, thus the default state is disabled, the only change in the interface is a gentle link below the textarea
  • some people don't like to be forced to use something new, so another vote for disabling by default
  • once users get used to the editor and will not report any major issues, the default mode can be changed
  • CKEditor needs a cool plugin to edit and insert source code ([code]) (in progress)
  • The "Source" mode in CKEditor and removing CKEditor from a textarea (calling editor.destroy()) are two different things. Being in "Source" mode means that we are still in CKEditor. In case of a bug with processing BBCodes a safer option would be to have this opportunity to "destroy" CKEditor instance and get back to plain textarea (CKEditor can be enabled later - basically destroying would work like in the ajax sample).

The ugly link below editor/textarea can be of course changed into e.g. more fancy tabs.
wiktor
Registered User
 
Posts: 6
Joined: Tue May 24, 2011 12:05 pm

Re: [RFC] WYSIWYG Editor

Postby imkingdavid » Wed Mar 07, 2012 3:53 pm

callumacrae wrote:I disagree with defaulting to the source view. I'm thinking of using cookies do that if a user changes it to source view, it is still in source view next time is opened. There will also be a UCP option to disable it entirely.

I disagree. Sometimes when on forums that have a rich editor, I write the post in source and then preview it in the rich editor and then post it without going back to source (no need). The next time I go to post I don't want to have to (again) click the source link.

So, imo, default to disabled when the feature is added. Then in UCP have an option whether to use it or not. On posting provide a way to switch between rich and source editors, but don't change default option when switch is done during posting.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 905
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] WYSIWYG Editor

Postby brunoais » Wed Mar 07, 2012 4:57 pm

imkingdavid wrote:So, imo, default to disabled when the feature is added. Then in UCP have an option whether to use it or not. On posting provide a way to switch between rich and source editors, but don't change default option when switch is done during posting.

+1
brunoais
Registered User
 
Posts: 627
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] WYSIWYG Editor

Postby bantu » Wed Mar 07, 2012 5:02 pm

brunoais wrote:
imkingdavid wrote:So, imo, default to disabled when the feature is added. Then in UCP have an option whether to use it or not. On posting provide a way to switch between rich and source editors, but don't change default option when switch is done during posting.

+1

+1

This is not a yes/no question however. Users should be able to pick their editor from a list.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
 
Posts: 439
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany

Re: [RFC] WYSIWYG Editor

Postby imkingdavid » Wed Mar 07, 2012 5:26 pm

bantu wrote:This is not a yes/no question however. Users should be able to pick their editor from a list.

Oh, I thought we were only looking into CKEditor. But I'm all for making it modular and allowing multiple options.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 905
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] WYSIWYG Editor

Postby DavidIQ » Wed Mar 07, 2012 7:42 pm

imkingdavid wrote:
bantu wrote:This is not a yes/no question however. Users should be able to pick their editor from a list.

Oh, I thought we were only looking into CKEditor. But I'm all for making it modular and allowing multiple options.

Ckeditor is almost fully configurable through config.js.
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 772
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: [RFC] WYSIWYG Editor

Postby MichaelC » Wed Mar 07, 2012 7:50 pm

Maybe even introduce it as a plugin system like the way CAPTCHA's and Authentication is done?

Then the plugin system can be added in 3.1 and then for 3.2 add CKEditor as a plugin added by default like reCAPTCHA is for as a CAPTCHA?
Unknown Bliss
psoTFX wrote:I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"

No unsolicited PMs please except for quotes.
User avatar
MichaelC
Website Team
Website Team
 
Posts: 798
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] WYSIWYG Editor

Postby VSE+ » Tue Mar 13, 2012 11:57 pm

Just some food for thought here...

How about, instead of trying to put in a WYSIWYG, do something like we see over on github - have a live preview button that will turn your post-box into a preview, using ajax and stuff so there is no reloading. And you can quickly bounce back and forth between Write and Preview modes if needed. Seems like a much easier task to implement than a WYSIWYG.
User avatar
VSE+
Registered User
 
Posts: 211
Joined: Mon Mar 08, 2010 9:18 am

Previous Next

Return to [3.x] RFCs

Who is online

Users browsing this forum: No registered users and 12 guests