phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Github IRC Service Hook

Discuss general development subjects that are not specific to a particular version like the versioning control system we use or other infrastructure.

Github IRC Service Hook

Postby MichaelC » Wed Mar 07, 2012 12:26 pm

When the github IRC service hook is enabled it will post a list of commits and their authors in the irc channel with a comparion link in this format:
Code: Select all
(12:20:14 PM) GHPB [~GHPB@sh1-ext.rs.github.com] entered the room.
(12:20:14 PM) GHPB: (notice) [phpBB-Blog-for-3.1] none pushed 3 new commits to master: https://github.com/phpBB-Blog/phpBB-Blog-for-3.1/compare/f440c84...5732ab9
(12:20:14 PM) GHPB: (notice) [phpBB-Blog-for-3.1/master] Merge pull request #59 from erikfrerejean/task/travis - Michael C.
(12:20:14 PM) GHPB: (notice) [phpBB-Blog-for-3.1/master] [task/local-test] Make tests locally runnable - Erik Frèrejean
(12:20:14 PM) GHPB: (notice) [phpBB-Blog-for-3.1/master] Merge pull request #60 from erikfrerejean/task/local-tests - Michael C.
(12:20:14 PM) GHPB left the room.


You just have to select server, port, room, nick and then select long url, notice and active.

For phpBB this might be:
Code: Select all
irc.freenode.net
6667
#phpbb-dev
GHPB - Github Push Bot, better to keep it short.


It makes sense as its instantly posted to the IRC chat. Its useful because it shows exactly what has been merged to those in the channel and quite often its being talked about when its merged. Often commit emails have a minute or two delay.

Its also highlights the person being merged so they are notified that its been merged if they are on-line. It also shows references in the IRC log to what people are talking about.
Unknown Bliss
psoTFX wrote:I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"

No unsolicited PMs please except for quotes.
User avatar
MichaelC
Website Team
Website Team
 
Posts: 798
Joined: Thu Jan 28, 2010 6:29 pm

Re: Github IRC Service Hook

Postby callumacrae » Wed Mar 07, 2012 3:36 pm

Check out CIA.vc. It is like this, but awesome (the GitHub one annoyed the hell out of me when I tried it). It's easy to set up, too.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Github IRC Service Hook

Postby MichaelC » Wed Mar 07, 2012 4:04 pm

If your running a small project with only 1 or 2 core contributors then yes, it would be annoying as you would know when you yourself push to the main repo. But for larger projects its quite useful.
Unknown Bliss
psoTFX wrote:I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"

No unsolicited PMs please except for quotes.
User avatar
MichaelC
Website Team
Website Team
 
Posts: 798
Joined: Thu Jan 28, 2010 6:29 pm

Re: Github IRC Service Hook

Postby callumacrae » Wed Mar 07, 2012 4:07 pm

CIA.vc is an IRC bot for GitHub.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Github IRC Service Hook

Postby sajaki » Wed Mar 07, 2012 6:03 pm

I'm using cia.vc for my projects and it's very nice. but it tends to be spam the channel if you commit alot.
sajaki
Registered User
 
Posts: 51
Joined: Mon Jun 21, 2010 8:28 pm

Re: Github IRC Service Hook

Postby callumacrae » Wed Mar 07, 2012 7:05 pm

sajaki wrote:I'm using cia.vc for my projects and it's very nice. but it tends to be spam the channel if you commit alot.

The GitHub one is far far worse :-)

I think it would be a good idea for phpBB to use via.vc (I'd be willing to set it up, all it needs is for a repo admin to enable the hook).
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Github IRC Service Hook

Postby imkingdavid » Wed Mar 07, 2012 7:44 pm

Perhaps we could have a separate #phpbb-commits channel or something? I don't like the idea of -dev getting spammed with commit notifications, since it can already be hard to follow discussions when more than one is going on at the same time.

Anyway, this would be something to bring up with nils and davidIQ and MarshalRusty.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
imkingdavid
Development Team
Development Team
 
Posts: 906
Joined: Thu Jul 30, 2009 12:06 pm

Re: Github IRC Service Hook

Postby MichaelC » Wed Mar 07, 2012 7:52 pm

imkingdavid wrote:Perhaps we could have a separate #phpbb-commits channel or something? I don't like the idea of -dev getting spammed with commit notifications, since it can already be hard to follow discussions when more than one is going on at the same time.

Anyway, this would be something to bring up with nils and davidIQ and MarshalRusty.


Well, to be honest things don't get pushed to the phpBB repo that often? Maybe once/twice every few days? I wouldn't see it as the channel being spammed.
Unknown Bliss
psoTFX wrote:I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"

No unsolicited PMs please except for quotes.
User avatar
MichaelC
Website Team
Website Team
 
Posts: 798
Joined: Thu Jan 28, 2010 6:29 pm

Re: Github IRC Service Hook

Postby callumacrae » Wed Mar 07, 2012 8:12 pm

Yeah, it would be a few messages every couple days, and it's for origin only.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Github IRC Service Hook

Postby naderman » Thu Mar 22, 2012 4:10 pm

github supports this as a built in hook. I'll enable that to see how it works. If anyone finds it annoying post here, and we can disable it again.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany


Return to General Development Discussion

Who is online

Users browsing this forum: No registered users and 6 guests