phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC] Clean up of prosilver code

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [RFC] Clean up of prosilver code

Postby callumacrae » Wed Mar 07, 2012 7:57 am

brunoais wrote:^
I don't know if the ppl here (the dev team) is open to a new template. I think it's a good idea to have a brand new template.
I'm support your idea. Prosilver is a good theme in the looks but contains bad coding. Subsilver2 is ok theme but in the code it is almost the house of the Adams family "...mysterious and spooky...".
I don't know how your way of writing HTML/CSS code to design works but I'll be much available to help you deciding how to implement design ideas into HTML/CSS. I also think that the dev team should also have a vote in that. We really need a clean CSS, a clean HTML, an HTML as expressive as it can (using HTML5) and to compact CSS itself. Actually a CSS merger & compacter and a js merger & compacter would be awsome for phpbb3!

We're going to be using Assettic to handle resources in 3.2.

While I like the idea of a new template, I definitely don't think that it should be done for 3.2. It would take far too long, and prosilver would have to be maintained anyway, for the benefit of other styles. I would maybe support a new style for 4.0.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] Clean up of prosilver code

Postby brunoais » Wed Mar 07, 2012 9:00 am

callumacrae wrote:While I like the idea of a new template, I definitely don't think that it should be done for 3.2. It would take far too long, and prosilver would have to be maintained anyway, for the benefit of other styles. I would maybe support a new style for 4.0.

We definitely need a new template for 4.0!
brunoais
Registered User
 
Posts: 626
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Clean up of prosilver code

Postby hanakin » Wed Mar 07, 2012 11:57 am

callumacrae wrote:
brunoais wrote:^
I don't know if the ppl here (the dev team) is open to a new template. I think it's a good idea to have a brand new template.
I'm support your idea. Prosilver is a good theme in the looks but contains bad coding. Subsilver2 is ok theme but in the code it is almost the house of the Adams family "...mysterious and spooky...".
I don't know how your way of writing HTML/CSS code to design works but I'll be much available to help you deciding how to implement design ideas into HTML/CSS. I also think that the dev team should also have a vote in that. We really need a clean CSS, a clean HTML, an HTML as expressive as it can (using HTML5) and to compact CSS itself. Actually a CSS merger & compacter and a js merger & compacter would be awsome for phpbb3!

We're going to be using Assettic to handle resources in 3.2.

While I like the idea of a new template, I definitely don't think that it should be done for 3.2. It would take far too long, and prosilver would have to be maintained anyway, for the benefit of other styles. I would maybe support a new style for 4.0.


What would take too long? design and coding it? if nothing else we need to start thinking of it in either aspect we can at least begin desing but for what I am think is something plain and basic yet still visually appealing. If we can can enough ppl with experience in all the areas it should be fairly easy. The hardest part to implement would be the JS as we need to replicate all the curretn functionallity into a new theme but it really needs to be rewritten and externalized essentially deign and code the theme semantically in flat html then go back through plit it up into the proper templates once that is achieved then add JS functionality it took me a whole month or two by myself to rewrite prosilver modern mock-up I did last year and that was with no help and rederic from the community.

I would hope it would or definately should be a lot cleaner than even that turned out as I was trying to replicate a design that was not planned for a proper semantic structure.

We need to list things out methodically what we need seperate it out in to groups of like features, what can be accomplish via a list what would be a drop down menu etc.. doing this will cut the coding time down before we even begin the design phase by litererally weeks as they would essentially be coded and styled once then tweaked slightly on an as needed bases sort of like a library of elements so to speak but on paper

I have been advicating this for over a year now that the main thing holding this effort back is mainly forum_fn.js, and the numerous inline functions in the theme that need to be summed up into psuedo at least to reimplement.

As mentioned earlier I am kind of in the middle of working on a redesign of my own site as well as tweaking my style as well and to work on another design would not be prudent as their would tend to be layover from own to the other I like to spread this out so that I code one and while design another to avoid this. However once I finish or get tot he heavy coding and finalize the design for my own project I will go full steam with this but until then I do not see any reason why we can not start a disscussion on the organization aspect that I mentioned above at least in the mean time. I literally have hrs out work where I can not really do anything but sit and troll in IE8 I want to take a "take our netwrok guys to the matresses!" somedays if you get the reference, but what can you do company policies and all.
hanakin
Registered User
 
Posts: 173
Joined: Sat Dec 25, 2010 9:02 pm

Re: [RFC] Clean up of prosilver code

Postby Dragosvr92 » Thu Mar 08, 2012 2:30 pm

I have just installed Firfox's Html Validator 0.9.5.1 addon and noticed the bellow errors with the round corners. Probably 3.2 will use border radius by then, but you might want to fix the corners issue in the next 3.0.11 release.
Attachments
phpbb span error.png
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: [RFC] Clean up of prosilver code

Postby Arty » Thu Mar 08, 2012 2:42 pm

Those are invalid errors. Empty spans are allowed.
Formerly known as CyberAlien.
User avatar
Arty
Styles Team
Styles Team
 
Posts: 796
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars

Re: [RFC] Clean up of prosilver code

Postby Dragosvr92 » Thu Mar 08, 2012 5:33 pm

Arty wrote:Those are invalid errors. Empty spans are allowed.

Yea, but cant there be used a better way than empty spans, and validate this things also?
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: [RFC] Clean up of prosilver code

Postby callumacrae » Thu Mar 08, 2012 5:48 pm

TheKiller wrote:
Arty wrote:Those are invalid errors. Empty spans are allowed.

Yea, but cant there be used a better way than empty spans, and validate this things also?

They're perfectly valid. The better way is border-radius, which is used in 3.1.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] Clean up of prosilver code

Postby hanakin » Fri Mar 09, 2012 2:58 am

callumacrae wrote:
TheKiller wrote:
Arty wrote:Those are invalid errors. Empty spans are allowed.

Yea, but cant there be used a better way than empty spans, and validate this things also?

They're perfectly valid. The better way is border-radius, which is used in 3.1.


? no its not or at least it is not merged if its being planned the css is there but the html is not using it. Their was an RFC by Arty but that is for 3.2
hanakin
Registered User
 
Posts: 173
Joined: Sat Dec 25, 2010 9:02 pm

Re: [RFC] Clean up of prosilver code

Postby Dragosvr92 » Sat Mar 10, 2012 1:30 am

I think i'vea heared that the phpbb version from here is 3.1 and it uses the same corner images as 3.0x

I had a copy of 3.1 once but i deleted it and i didnt look on the changes >,<
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: [RFC] Clean up of prosilver code

Postby callumacrae » Sat Mar 10, 2012 6:40 am

I don't think it has been implemented yet, but iirc, it was decided that it would use border-radius.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Previous Next

Return to [3.x] RFCs

Who is online

Users browsing this forum: No registered users and 6 guests