[RFC] Revamp of styles section of acp

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
DavidIQ Online
Customisations Team Leader
Customisations Team Leader
Posts: 1867
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Revamp of styles section of acp

Post by DavidIQ »

imkingdavid wrote:
DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
Just in case you're confusing terminology, installed != active. Yes there are requirements for parent styles to be installed before child styles are, but the parent style does not have to be active for child styles to be.
That's exactly what I was doing. :roll:
Thanks!
Image
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

Maybe change terminology for it?
Active = Visible
Inactive = Hidden
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revamp of styles section of acp

Post by imkingdavid »

Personally, I think we should make the terminology consistent across styles and extensions. Currently, there's enabled/disabled and active/inactive. We should choose one and use it globally.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

imkingdavid wrote:Personally, I think we should make the terminology across styles and extensions. Currently, there's enabled/disabled and active/inactive. We should choose one and use it globally.
That makes sense. As I'm rewriting acp_styles module anyway, changing terminology won't be a problem. What will it be?
User avatar
Jacob
Registered User
Posts: 102
Joined: Wed Jan 04, 2012 1:41 pm

Re: [RFC] Revamp of styles section of acp

Post by Jacob »

My vote for active/inactive, I think it's clearer.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revamp of styles section of acp

Post by imkingdavid »

Arty wrote:
imkingdavid wrote:Personally, I think we should make the terminology across styles and extensions. Currently, there's enabled/disabled and active/inactive. We should choose one and use it globally.
That makes sense. As I'm rewriting acp_styles module anyway, changing terminology won't be a problem. What will it be?
Well, personally I'd go for the "active/inactive" way it currently is for styles. However, we'll probably need input from some more people (i.e. oleg, igorw, naderman, etc.) to make a decision.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

Merging styles components made old acp_styles useless, therefore this RFC is now part of [RFC] Merge style components and is included in pull request for that RFC.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

Moved from 3.2 to 3.1 RFC forum.

Part of this RFC is already merged with [RFC|Merged] Merge style components

Still to do:
- Ability to edit templates in admin control panel
- Remove entries that are no longer used from language/en/acp/style.php
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Oleg »

(16:18:31) an-: we lost all options when installing a style
(16:18:37) an-: set as active/default/force users to use it
(16:18:41) an-: cyberalien: ^
(16:19:29) an-: was this discussed? approved?
(16:19:37) cyberalien: an-: no, you didn't. new acp_styles lets you activate/deactivate it. focing users to use it was never in acp_styles, its in configuration
(16:19:38) an-: is it coming back?
(16:23:40) an-: cyberalien: no, do i need to make a screenshot?
(16:23:55) cyberalien: yes
(16:23:59) an-: ok
(16:24:05) cyberalien: that would be helpful to figure out why you don't see it
(16:26:35) an-: step1 3.0 http://postimage.org/image/8r2sov3zx/b59b501a/
(16:26:53) an-: step2 3.0 http://postimage.org/image/r27uve5yb/d96f5082/
(16:27:51) an-: i see these options are now under 'details'
(16:27:54) an-: once the style is installed
(16:28:13) cyberalien: oh, during installation. that page doesn't exist in new acp_styles, but it lets you install several styles at once
(16:28:17) an-: the language there is really not ideal
(16:28:42) an-: for admins used to 3.0
(16:28:55) an-: basically stuff just disappeared
(16:29:13) cyberalien: i can add that back when user is installing only 1 style
(16:29:28) an-: Here you can manage the available styles on your board. You may alter existing styles, delete, deactivate, reactivate, install new ones.
(16:29:37) an-: on that particular screen uninstalled styles are no longer displayed
(16:29:48) an-: you have to go to install styles in the sidebar
(16:30:06) an-: maybe add a link below style list to install styles?
(16:30:48) cyberalien: good idea too
(16:31:46) an-: Style "subsilver2" has been installed.
(16:31:46) an-: Click here to return to installed styles list.
(16:32:26) an-: maybe add a line to the effect of "click here to set this as default style or change style settings" which leads to details page
(16:32:39) cyberalien: 3 links will be confusing to user
(16:33:25) cyberalien: maybe add radio box to installed styles list, allowing user to quickly switch default style?
(16:33:27) an-: well i don't know
(16:33:44) cyberalien: that would be less confusing and user will immediately see it
(16:34:07) an-: maybe split actions into multiple columns
(16:34:14) an-: if details is in its own column it might be easier to see
(16:34:26) an-: however "details" does not imply "settings" or "options"
(16:34:44) an-: and as a matter of fact in 3.0 details is in its own column titled options
(16:34:53) an-: so that maybe should go back to the way it was
(16:36:00) cyberalien: i'm not sure about that, but i'll add it to see if it helps
User avatar
oddfish
Registered User
Posts: 110
Joined: Tue Mar 27, 2007 5:53 am
Location: on my way home
Contact:

Re: [RFC] Revamp of styles section of acp

Post by oddfish »

'No uninstalled styles detected.' string under Styles Management -> Install Styles should reflect no styles available to install.
Post Reply