[RFC|Merged] Merge style components

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty »

naderman wrote:I'd say +1, if we implement some kind of theme inheritance, too and allow multiple levels of inheritance.
Oh, I do like that idea! Imagine being able to clone theme by customizing only colours.css

New RFC incoming

User avatar
hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 935
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Merge style components

Post by hanakin »

+3 million anything and everything to simplify the mess of theme development and progress it towards the current/next standard I am all for. Personally I am can not fathom ppl who use the current inheritance method or any for that matter, this provides a clean way to allow those who would be :evil: to do so gracefully.
Donations welcome via Paypal Image

marian0810
Former Team Member
Posts: 16
Joined: Sun Jul 25, 2010 11:31 am
Location: The Netherlands
Contact:

Re: [RFC] Merge style components

Post by marian0810 »

Arty wrote:
marian0810 wrote:I actually use that a lot :?
What components are you mixing?
Most of my extra styles only have a theme folder and an imageset, using the template of subsilver2.
Don' t Cry Because It's Over
Smile Because It Happened

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty »

Then its not a problem at all. Define template inheritance in style.cfg (currently in template.cfg) and you don't need to copy templates.

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty »


User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty »

First part of patch is available for testing: https://github.com/phpbb/phpbb3/pull/573

Everything is working, except for styles management in admin control panel.

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty »

First version of styles management is ready. You can find it here: https://github.com/phpbb/phpbb3/pull/577

What is included so far:
  • Merged style components (this RFC) - complete
  • Unlimited parent styles tree (RFC) - complete
  • Revamp of acp_styles (RFC) - incomplete
What isn't done yet:
  • Editing templates via admin control panel
  • Purging templates cache via acp_styles (you have to click "purge cache" button on acp index instead)
  • Terminology for template inheritance / parent styles and for disabled / hidden / inactive styles (see this post and few posts below it)
  • Removing old entries from language/en/acp/styles.php (some entries have been removed)
Everything that is available so far should work. You should be able to install or upgrade forum, you should be able to use all existing styles management functions.

To test template inheritance, I've uploaded pack of styles here: download
It is compressed version of my "styles" directory, includes prosilver, subsilver2 and bunch of prosilver clones made with colorizeit. Most of them have dummy template inheritance set up, some are missing templates in order to test inheritance.

You can create more clones by using function "colorize my files" when editing prosilver on colorizeit.

ecwpa
Registered User
Posts: 181
Joined: Mon Jan 24, 2005 2:10 am
Contact:

Re: [RFC] Merge style components

Post by ecwpa »

Not sure if this is the right place to ask but, is there a way to not caché templates? This is extrictly for styles developers who don't want to be clearing caché every time you make a change.
Slightly better English than it was in 2005, still improving :D

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Merge style components

Post by Arty »

admin control panel -> load settings -> recompile stale style components -> enable

ecwpa
Registered User
Posts: 181
Joined: Mon Jan 24, 2005 2:10 am
Contact:

Re: [RFC] Merge style components

Post by ecwpa »

Thanks! Thats a weird name for that option though.
Slightly better English than it was in 2005, still improving :D

Post Reply