[RFC|Merged] Rounded corners via css

[wGEric]

Make sure you look at the known issues for pie. There is one about serving the correct content type that will affect how it needs to be implemented. To make sure it actually works on every server you will probably have to use the php method.

[Arty]

But maybe you should do the fallowing:

If Google Chrome Frame is not installed, you can direct your users to an installation page.

That is a bad idea. Forum should work for users, not force them to install some addons. Such approach will only annoy users, causing them to switch to other forum solutions.

Make sure you look at the known issues for pie. There is one about serving the correct content type that will affect how it needs to be implemented. To make sure it actually works on every server you will probably have to use the php method.

That's bad
Thanks for finding it.

[imkingdavid]

But maybe you should do the fallowing:

If Google Chrome Frame is not installed, you can direct your users to an installation page.

That is a bad idea. Forum should work for users, not force them to install some addons. Such approach will only annoy users, causing them to switch to other forum solutions,

+1 phpBB should work out of the box without requiring users to go install even more things. Of course, depending on their browser that may mean a less than optimal browsing experience (although with IE, that's to be expected ), but that's neither our fault nor our problem. We do what we can to make the experience as similar across browsers as possible, understanding that some browsers don't play as nicely as others. Major features should definitely take such things into account, even to the point of leaving them out if not all users will be able to use them, but something like rounded corners isn't a major feature. Besides, pointy corners aren't all bad, and the page load will decrease because the image won't have to be loaded each time.

[Ger]

+1 phpBB should work out of the box without requiring users to go install even more things. Of course, depending on their browser that may mean a less than optimal browsing experience (although with IE, that's to be expected ), but that's neither our fault nor our problem. We do what we can to make the experience as similar across browsers as possible, understanding that some browsers don't play as nicely as others. Major features should definitely take such things into account, even to the point of leaving them out if not all users will be able to use them, but something like rounded corners isn't a major feature. Besides, pointy corners aren't all bad, and the page load will decrease because the image won't have to be loaded each time.

+1.

[callumacrae]

But maybe you should do the fallowing:

If Google Chrome Frame is not installed, you can direct your users to an installation page.

That isn't phpBB's place to do, I would strongly disagree with it.

I'd rather skip any IE specific workarounds like PIE, and just go with the CSS3 solution. Not having rounded corners is really not the end of the world.

+1

[Dragosvr92]

Well i say to just get on with the CSS3 propertys and ignore IE, Like Naderman said.
Its okay if they dont see round corners, not really a big issue. If they want performance they should upgrade their browsers, same like with operating systems. I guess the PIE Option could be made into a MODification and the forum owners can add it if they feel like it. The MOD Could have a module that enables the PIE Addon and a warning message to upgrade to a modern browser, or at least IE9. Or... add two options for PiE And Google Chromes frame..... Theres too many ifs.. i sort of get confused in writing

[hanakin]

seeing as how i first proposed it obviously +1 lol also something to consider al be it not related to round corners but if we do away with all the gradients on the forums and the header and change the color scheme we can also eliminate the need for alot of the image overhead as well making the theme load faster more along the lines of subsilver, coupled with the dynamic sprite concept that was in the works if it ever gets implemented will completely streamline the theme. Only thing left from their as far as theme improvements go from the original topic is the HTML/CSS restructure into a cleaner and more semantic file. but really need to completely externalize the JS before that can/should happen

[Arty]

Updated first post, created ticket.

[Arty]

This RFC was solved by Shibu Lijack and merged.

PR: https://github.com/phpbb/phpbb3/pull/674

[Vinny]

border-radius should be applied to docs/stylesheet.css too.

As per IRC, images/corners_left.png and images/corners_right.png can be removed. @cyberalien mentioned that having to add that clear class everywhere is not so nice.

Any reason to keep the images corners_left2.gif and corners_right2.gif?