PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by jsebean » Mon Jan 10, 2011 4:44 pm

Ticket: https://tracker.phpbb.com/browse/PHPBB3-10418
PR: https://github.com/phpbb/phpbb/pull/3630
-----------

Since i dont think WYSIWYG will be included in 3.1 (if there is please correct me), what about WYSIWYG editor for phpBB 3.2.
Last edited by jsebean on Sun Mar 25, 2012 12:57 pm, edited 1 time in total.
-Jonah

simy202
Registered User
Posts: 1
Joined: Thu Jan 13, 2011 1:26 am
Location: United States
Contact:

Re: [RFC] WYSIWYG Editor

Post by simy202 » Thu Jan 13, 2011 1:28 am

So has CKEditor been integrated into Area 51?

What kind of (x)HTML tags does ckeditor allow? And which tags don't they allow to be used?

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] WYSIWYG Editor

Post by jsebean » Thu Jan 13, 2011 2:21 pm

Well if I understand your question correctly CKEditor is not integrated into area51.

I have read discussion related to having the team integrate CKEditor, but I didn't get much information out of it that's why I made this RFC.
-Jonah

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] WYSIWYG Editor

Post by DavidIQ » Thu Jan 13, 2011 4:34 pm

Well the CKEditor folks want to work with us it's just a matter of figuring out what the dev team wants to do with it.
Image

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] WYSIWYG Editor

Post by jsebean » Thu Jan 13, 2011 9:04 pm

OK thanks. I saw the posts from CKEditor folks but didn't know really what was going on, that basically sums it up 8-)
-Jonah

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] WYSIWYG Editor

Post by jsebean » Sun Jan 08, 2012 8:23 pm

From discussions and comments I've seen, CK folks seemed to not have the people to develop this and think it should be responsibility of phpBB devs. Any updates on the progress of this?

ETA: http://cksource.com/forums/viewtopic.ph ... b&start=10
-Jonah

wGEric
Registered User
Posts: 521
Joined: Wed Jun 11, 2003 2:07 am
Contact:

Re: [RFC] WYSIWYG Editor

Post by wGEric » Wed Jan 11, 2012 6:03 pm

I would suggest calling this a Rich Text Editor instead of a WYSIWYG. More than likely it won't be a true WYSIWYG.

Here is a BBCode parser I wrote using javascript. It uses the same tags that phpBB has for custom bbcodes ({TEXT}, {SIMPLETEXT}, etc). It can convert bbcode to html and html to bbcode. Something like this should allow custom bbcodes to be added and wouldn't change massive amounts of code if the built in bbcodes are switched to "custom" ones.

Here is an example ckeditor plugin that uses the above parser.

One question I have is about custom bbcodes or even the quote bbcode. The quote bbcode contains something like "x said:". You don't want people to be able to change "said:". You only want them to be able to change "x". Same could go for spoiler bbcodes that have something like "Spoiler:" in them.

If you set contenteditable="false" on elements then CKEditor won't allow those to be edited (seems like it may not work in some browsers but I can't find the documentation about this at the moment). So that would be the solution but do you attempt to add that attribute automatically or do you require people to add another HTML template that is used for the editor?
Eric

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] WYSIWYG Editor

Post by DavidIQ » Wed Jan 11, 2012 6:14 pm

jsbean wrote:From discussions and comments I've seen, CK folks seemed to not have the people to develop this and think it should be responsibility of phpBB devs. Any updates on the progress of this?

ETA: http://cksource.com/forums/viewtopic.ph ... b&start=10
I'm not sure how you came to that conclusion. This ticket says they've coded a BBCode parser and looks to have been merged to their main branch:
http://dev.ckeditor.com/ticket/7044

About a month ago there was also a MOD submitted for 3.0.9 (denied):
http://www.phpbb.com/customise/db/mod/ckeditor/

So it's apparently already possible with the current CKEditor release.
Image

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] WYSIWYG Editor

Post by callumacrae » Wed Jan 11, 2012 6:59 pm

That mod was pretty, but it was literally just CKEditor stuck on top of phpBB - the quotes didn't look like phpBB quotes, and the font was different. That mod would be alright to be put into phpbb, but I think that it would be better if it used only hooks, and it would need some modification so that what you see in the editor is what is put into the end post.

EDIT: I think CKEditor is ugly, though :-(
Made by developers, for developers!
My blog

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] WYSIWYG Editor

Post by MichaelC » Thu Jan 12, 2012 12:19 am

I think it should probably be better integrated with phpBB if its to be included in the core.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply