Stop cutting off images when "too" wide...

[doktornotor]

Really cannot believe this still has not been fixed.

Open: styles/prosilver/theme/common.css

Find:

Code: Select all

img {
   border-width: 0;
}


Replace with:

Code: Select all

img {
   border-width: 0;
   max-width: 100%;
}


This is extremely annoying when people post screenshots, the issue can be seen in loads of thread on the forum here.

[naderman]

Please create a ticket on the bug tracker for this, thanks!

[doktornotor]

Sure thing, will do ASAP.

[Arty]

That's a bad solution. It will affect all images, not only images in posts, including custom logos, ads, etc. If you want to resize image, add code for

Code: Select all

.postbody img

[doktornotor]

That's a bad solution. It will affect all images, not only images in posts, including custom logos, ads, etc. If you want to resize image, add code for

Code: Select all

.postbody img

Well, when your logos/ads end up being cut off, you have a bigger problem I guess? Ideally, you should get a full sized image popup after clicking on the shrinked one, which would involve changing the following line in includes/bbcode.php to something suitable for that purpose

Code: Select all

'img'      => '<img src="$1" alt="' . $user->lang['IMAGE'] . '" />',


Ideally, bundling something like the ReIMG Image Resizer mod would solve all this but that is something left for 3.1.x at best, I'm afraid. Either way, getting the images cut off abruptly is really the worst solution out there.

P.S. Adding the ticket reference: PHPBB3-10543.

[AmigoJack]

Personally I dislike resizings (browsers on slow computers are not amused with that). Everything that's missing is a scrollbar in such a case, like you already find it for decades in almost every UI (aka overflow: auto;).

[canonknipser]

Personally, i dislike large images in post at all for different reasons.
But in my opinion resizing is much better than having a scrollbar
It should have no effect on browser performance, because in both cases the browser has to load the image complete. Having full-size images, it will break the design of the page, because every content on the right goes off and you have to scroll horizontal, the image is not shown "at a glance" (the same like cutting it!).
Think about hi-res images from a modern DSLR, 6,000px horizontal means you have to scroll 5 complete pages on a 1024px browser window.

[callumacrae]

It should have no effect on browser performance, because in both cases the browser has to load the image complete.

It most certainly will have an affect!

[doktornotor]

But in my opinion resizing is much better than having a scrollbar

Yeah, horizontal scrollbars are horrible and break the entire layout.

[Ger]

See tracker for proposed fix:
http://tracker.phpbb.com/browse/PHPBB3-10543