Submitting patch for 3.0.9

[josno]

I've just created a ticket (10439) for which I have a patch. I noticed that the develop branch has changed the way the ACM is organised and so I altered my patch accordingly. However, I've since noticed the develop-olympus branch. Which should I base my git branch on?

[t_backoff]

The develop-olympus is the branch for 3.0.x. The develop branch is 3.1.x.

[Oleg]

Normally in these situations one would create two pull requests, one for develop-olympus and one for develop.

This assumes the changes will in fact be acceptable for 3.0; if they turn out to be too big for 3.0 then you only need to create a pull request against develop.

Right now the ticket does not have a fix version, which is because it does not have the information necessary to determine what version the fix should go in. Thus I would suggest putting all of the changes you have on github for review. If you already made changes against both 3.0 and 3.1 create two branches, one for each set of changes.

[josno]

Great, thanks for your replies. I didn't include much in my ticket because I thought my code would be fairly self-explanatory. We'll see!

[Oleg]

The patch is looking good to me, except the newline at the end must be taken out for develop-olympus.

Do you have the develop version as well? If so please create a separate pull request with it.

[naderman]

Hey, I closed your ticket, because the patch doesn't actual improve performance. But I would like to thank you for working out how to contribute, and hope you'll still contribute something else in the future!

[josno]

I've commented on the pull request and ticket. Let me know how I can prove to you it's quicker!