[RFC|Merged] Removal of imagesets

[Arty]

What for? All language specific css should be in theme/{lang}/stylesheet.css, so you don't need it

[Dakin Quelia]

It is interesting to include the variables, which define the paths and which allow not to modify each path but with a general varibable, it would be easier to update all these paths.

[Arty]

But why? What do you need to include?

[Dakin Quelia]

It's easier to modify a single path (via {T_THEME_PATH} or {T_THEME_LANG_PATH}) in php file rather than modify each CSS file to fix the image path (lang or not)... ?

[Arty]

What path? There is only one path for images: ./images/, that's all. In language specific css file its ./

I think you don't know how urls in css files work. They are relative to css file, NOT to document. So its not styles/prosilver/theme/images/whatever.png, but images/whatever.png

[leviatan21]

What about New template variables
Use much less css instead duplicated code for different languages

[nickvergessen]

What about New template variables
Use much less css instead duplicated code for different languages

the only thing that is duplicated for different languages are the language strings themselves

[canonknipser]

What about New template variables
Use much less css instead duplicated code for different languages

the only thing that is duplicated for different languages are the language strings themselves

Maybe not - some languages are very similar, so you can think about "inherited" languages, eg. "en" -> "en-us" or "de" -> "de-at", because in those "dialects" only a few words differ from the basic language

[nickvergessen]

Just what I said?! You don't need any images more from now on, you can just change your css file and make it point to the original images?

[nextgen]

the css classes at the stylesheet root/styles/prosilver/theme/en/stylesheet.css are wrong :
This :
.imageset.button_topic_new {
Should ber :
.post-icon span {

because there are no call to any class named .imageset or .button_topic_new in the template, if you duplicate the file root/styles/prosilver/theme/en/stylesheet.css to another language and put your images inside that folder are never used, at least for big buttons and post buttons in prosilver style.

This is a fixed example for Spanish (es) language.

Code: Select all

/* Set big button dimensions */
.buttons div.reply-icon      { width: 96px; height: 25px; }
.buttons div.post-icon      { width: 96px; height: 25px; }
.buttons div.locked-icon   { width: 88px; height: 25px; }
.buttons div.pmreply-icon   { width: 96px; height: 25px; }
.buttons div.newpm-icon      { width: 84px; height: 25px; }
.buttons div.forwardpm-icon   { width: 96px; height: 25px; }

/* Set profile icon dimensions */
ul.profile-icons li.pm-icon      { width: 28px; height: 20px; }
ul.profile-icons li.quote-icon   { width: 54px; height: 20px; }
ul.profile-icons li.edit-icon   { width: 42px; height: 20px; }

 /* ES Language Pack */
.pm-icon, .pm-icon a {
    background-image: url("./icon_contact_pm.gif");
}
.edit-icon, .edit-icon a {
   background-image: url("./icon_post_edit.gif");
}
.quote-icon, .quote-icon a {
   background-image: url("./icon_post_quote.gif");
}
.forwardpm-icon span {
    background-image: url("./button_pm_forward.gif");
}
.newpm-icon span {
    background-image: url("./button_pm_new.gif");
}
.pmreply-icon span {
    background-image: url("./button_pm_reply.gif");
}
.online {
    background-image: url("./icon_user_online.gif");
}
.locked-icon span {
    background-image: url("./button_topic_locked.gif");
}
.post-icon span {
   background-image: url("./button_topic_new.gif");
}
.reply-icon span {
   background-image: url("./button_topic_reply.gif");
}