[RFC|Accepted] Overridable imageset and theme paths for CDNs

[Oleg]

All occurrences of image references in phpbb can (currently) be found with a fairly small number of regular expressions. I run several global search and replace operations to append timestamps to my asset urls in deployment. These timestamps allow me to cache assets indefinitely via expires headers (while serving them from the same vhost as the scripts).

I suspect it would not be too hard to transform relative paths into absolute urls, based on which file the paths occur in.

Now, this assumes you are not generating stylesheets on the fly via style.php. If you do, if my memory is correct you would need some less trivial changes to phpbb code to timestamp assets.

[Rahul]

I need to ask 1 thing... how can these changes automatically select http or https depending upon the way header request them?

[Sierron]

+1

I would love to have that without needing to rewrite everything.

I would use a subdomain to get the parallel downloads: like subdomain.mysite.com.

That

[Rahul]

Code: Select all

imageset:
in session.php
Code: Select all$img_data['src'] = 'http://cdn.varjanta.com/static/' . rawurlencode($this->theme['imageset_path']) . '/imageset/' . ($this->img_array[$img]['image_lang'] ? $this->img_array[$img]['image_lang'] .'/' : '') . $this->img_array[$img]['image_filename'];

What about theme images? Images that load from theme folder...what setting we must do?

[nickvergessen]

Well we removed the imagesets, so this RFC needs to be adjusted a bit

[Oleg]

http://www.phpbb.com/community/viewtopi ... #p13102378

It is fairly straightforward to find all references to static assets in phpbb via regular expressions. The challenge is that image urls and such are relative, not absolute. You would have to process each level of files separately to properly convert relative to absolute urls. Then you could prepend host and path to the urls to make all urls point to the cdn of your choice.

You can use my asset timestamping script for inspiration: https://gist.github.com/1645495 (built and tested against phpbb 3.0.5 or so).