phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Including a default Favicon for fresh instalations

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!

Re: Including a default Favicon for fresh instalations

Postby Vinny » Tue Aug 23, 2011 11:03 pm

CyberAlien wrote:What if website already has a favicon in root directory? Having a favicon in style would overwrite it, so I think its a bad idea.

Good point :idea: , so should have an option to enable/disable the favicon.
User avatar
Vinny
Styles Team
Styles Team
 
Posts: 91
Joined: Thu May 20, 2010 4:01 am
Location: Brazil

Re: Including a default Favicon for fresh instalations

Postby DavidIQ » Wed Aug 24, 2011 12:01 am

How about we disable it by not including a reference to it in the header and if you want it you can manually edit the header file and add it? ;)
Image
User avatar
DavidIQ
MOD Team Leader
MOD Team Leader
 
Posts: 759
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth

Re: Including a default Favicon for fresh instalations

Postby Dragosvr92 » Wed Aug 24, 2011 11:42 am

DavidIQ wrote:How about we disable it by not including a reference to it in the header and if you want it you can manually edit the header file and add it? ;)

hahaha ....... :roll:
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Including a default Favicon for fresh instalations

Postby Dragosvr92 » Fri Mar 23, 2012 11:24 pm

I'm back ! :mrgreen:

Why dont we just include this image:Image in the phpbb3 release?
In my opinion it is perfect for this and it represents the software. :|
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Including a default Favicon for fresh instalations

Postby BullsNet » Fri Mar 30, 2012 8:31 pm

+1 phpBB should have one when you fresh install.
BullsNet
Registered User
 
Posts: 22
Joined: Fri Sep 17, 2010 5:23 pm

Re: Including a default Favicon for fresh instalations

Postby Senky » Sun Jun 24, 2012 6:22 pm

Well, I am certainly for. If we include it, it makes no harm (if phpBB is not in root directory, it will be ignored, if it is, it shows up). As TheKiller said, if prosilver can have phpBB logo included, why phpBB itself cannot afford adding favicon?

Next argument for is that it (in certain conditions) removes apache (or other server system) errors (usually written in logs), because no favicon means one e404 request.

But it cannot be included in <head>, for sure not!
Senky
Registered User
 
Posts: 222
Joined: Thu Jul 16, 2009 4:41 pm

Re: Including a default Favicon for fresh instalations

Postby naderman » Sun Jun 24, 2012 11:07 pm

I agree we should include a favicon by default. I agree though that we should only include a default favicon.ico file, and not add an element to head for it, so that site which already have a favicon.ico keep theirs.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: Including a default Favicon for fresh instalations

Postby Senky » Tue Jul 17, 2012 10:02 am

So what is the final decision? Can a ticket be created?
Senky
Registered User
 
Posts: 222
Joined: Thu Jul 16, 2009 4:41 pm

Re: Including a default Favicon for fresh instalations

Postby Oleg » Tue Jul 17, 2012 3:56 pm

Include a favicon but not call it favicon.ico?
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: Including a default Favicon for fresh instalations

Postby Senky » Tue Jul 17, 2012 5:54 pm

No, naderman meant including favicon.ico named favicon.ico, included in root of phpBB, but do not add it into overall_header <head> tag. If favicon is not included in <head>, browser tries to load it from root of domain (eg area51.phpbb.com/favicon.ico), so if administrator changes it, it will display custom favicon, but if it does not change it, it will display phpBB's default favicon.
Senky
Registered User
 
Posts: 222
Joined: Thu Jul 16, 2009 4:41 pm

Previous Next

Return to [3.0/Olympus] Discussion

Who is online

Users browsing this forum: No registered users and 11 guests