phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

Including a default Favicon for fresh instalations

Discussion of general topics related to the new version and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!
Forum rules
Discussion of general topics related to the new release and its place in the world. Don't discuss new features, report bugs, ask for support, et cetera. Don't use this to spam for other boards or attack those boards!

Re: Including a default Favicon for fresh instalations

Postby callumacrae » Sat Aug 13, 2011 9:32 am

TheKiller wrote:I dont know what do you mean by a timestamp for favicon loading... :?

It reduces the need to download it to see whether it has changed. Say the timestamp is the same as the timestamp of the favicon in the cache, it knows the favicon is up to date. If the timestamp is greater, it will download the updated favicon.

~Callum
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Including a default Favicon for fresh instalations

Postby Dragosvr92 » Mon Aug 15, 2011 3:42 pm

Well my idea still stands. Would be nice to include a favicon.ico which describes phpbb :D
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Including a default Favicon for fresh instalations

Postby callumacrae » Tue Aug 16, 2011 12:28 pm

TheKiller wrote:Well my idea still stands. Would be nice to include a favicon.ico which describes phpbb :D

I disagree with this - the favicon should reflect the site, not the software that powers it.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Including a default Favicon for fresh instalations

Postby Dragosvr92 » Tue Aug 16, 2011 12:57 pm

callumacrae wrote:
TheKiller wrote:Well my idea still stands. Would be nice to include a favicon.ico which describes phpbb :D

I disagree with this - the favicon should reflect the site, not the software that powers it.

You kinda have a point... But prosilver comes with the phpbb logo, right?
The people can change it if they wish with their own.
The Instalation could come with a favicon, and people could just replace the existing favicon with their own, same as they do with the phpbb logo.

If im not mistaken Internet Explorer Requests the favicon in the root or otherwise it will fill your error log with the missing favicon.
EDit:
The Favicon could be also the default no-icon from firefox, or just a transparent 1px image. just so you wont have the missing error. :)
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Including a default Favicon for fresh instalations

Postby callumacrae » Tue Aug 16, 2011 2:48 pm

That's just IE being rubbish, it is not the responsibility of either the forum owner or the forum software to work around this.

~Callum
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 882
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: Including a default Favicon for fresh instalations

Postby Dragosvr92 » Tue Aug 16, 2011 4:14 pm

callumacrae wrote:That's just IE being rubbish, it is not the responsibility of either the forum owner or the forum software to work around this.

~Callum

I know, but i think it might be nice to make it work under any browsers :)
i personally hate All IE Versions. And i dont feel we should support them. But it would be nice to make your site look nice, even if some dumb persons dont get over it and upgrade to a modern browser.

Well, i gave my point. If you think this should be included fine :)
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Including a default Favicon for fresh instalations

Postby bantu » Tue Aug 23, 2011 3:52 pm

Please take the following into account:
  • There is no guarantee that phpBB is installed in the web root.
  • Different folders can have different favicons.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
 
Posts: 437
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany

Re: Including a default Favicon for fresh instalations

Postby Dragosvr92 » Tue Aug 23, 2011 8:06 pm

bantu wrote:Please take the following into account:
  • There is no guarantee that phpBB is installed in the web root.
  • Different folders can have different favicons.

Good point. I take back my suggestion :?
Maybe just include the favicons into the style and load them by html, ? :lol:
Previous username: TheKiller
Avatar on Memberlist 1.0.3
User avatar
Dragosvr92
Registered User
 
Posts: 358
Joined: Tue May 31, 2011 12:08 pm
Location: Romania

Re: Including a default Favicon for fresh instalations

Postby Vinny » Tue Aug 23, 2011 8:23 pm

Vinny wrote:It would be better in: /images/ or styles/(style-name)/theme/images/

bantu wrote:There is no guarantee that phpBB is installed in the web root.

TheKiller wrote:Maybe just include the favicons into the style and load them by html, ?


I think it looks good in styles. A style author would like to insert a favicon with the theme of style.
User avatar
Vinny
Styles Team
Styles Team
 
Posts: 91
Joined: Thu May 20, 2010 4:01 am
Location: Brazil

Re: Including a default Favicon for fresh instalations

Postby Arty » Tue Aug 23, 2011 8:46 pm

What if website already has a favicon in root directory? Having a favicon in style would overwrite it, so I think its a bad idea.
Formerly known as CyberAlien.
User avatar
Arty
Styles Team
Styles Team
 
Posts: 796
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars

Previous Next

Return to [3.0/Olympus] Discussion

Who is online

Users browsing this forum: No registered users and 9 guests