[RFC] Show New Topic Button on Viewtopic

[DavidIQ]

I don't like the idea of a button either. Perhaps a link under the Reply button might be ok sort of how the Reply All feature is in PMs.

[callumacrae]

Preview:

Code: Select all

var buttons = document.getElementsByClassName('buttons');
for (var i = 0; i < buttons.length; i++)
{
  buttons[i].innerHTML += '<div class="post-icon" title="Post a new topic"><a href="./posting.php?mode=post&f=108"><span></span>Post a new topic</a></div>';
}

It doesn't look bad, but I don't like it - it's not really necessary and it's just yet another button.

~Callum

[DavidIQ]

That JavaScript is rather bleh...what happened to your jQuery-Fu?

[callumacrae]

I can't use jQuery when it isn't loaded

EDIT: However, if it were:

Code: Select all

$('.buttons').append('<div class="post-icon"><a href="./posting.php?mode=post&f=108"><span></span>Post a new topic</a></div>');

[DavidIQ]

That makes no sense. You're doing the above before the page loads? That would be the only time jQuery wouldn't be available and it would make no sense to do what you posted at that point. Besides that why would you even consider creating this button using javascript?

P.S. you do realize jQuery is being added in 3.1 right?

[callumacrae]

That makes no sense. You're doing the above before the page loads? That would be the only time jQuery wouldn't be available and it would make no sense to do what you posted at that point. Besides that why would you even consider creating this button using javascript?

P.S. you do realize jQuery is being added in 3.1 right?

I put all JavaScript in the page footer. It isn't how I think it should be added, it is just showing people who can't be bothered to edit prosilver what it looks like.

Yes xD

[DavidIQ]

I don't remember seeing anyone say jQuery would go in the footer. It wouldl likely go in the header where we have all other javascript...

Back on topic: I still don't quite like the idea.

[AmigoJack]

The reason for removing it, as I understand it, was that too many people would click the New Topic button instead of New Reply when viewing a topic so they would start a new topic with their reply. Yes, it would be nice to have both buttons if people were more observant, but they aren't.

Good objection. On my board the "new topic" button while viewing a topic is a real benefit, but looking to the general phpBB user I'm sure there would be more problems when implementing this as default.

[Dragosvr92]

I Disagree ! My style had the post new topic in the viewtopic page and it confused me more. i never used it.
You are inside the topic and you are going to post a reply, not a new topic.